From: Anshuman Khandual <anshuman.khandual@arm.com>
To: linux-mm@kvack.org
Cc: Anshuman Khandual <anshuman.khandual@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Michal Hocko <mhocko@suse.com>, Vlastimil Babka <vbabka@suse.cz>,
Oscar Salvador <osalvador@suse.de>,
Mel Gorman <mgorman@techsingularity.net>,
Mike Rapoport <rppt@linux.ibm.com>,
Dan Williams <dan.j.williams@intel.com>,
Pavel Tatashin <pavel.tatashin@microsoft.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages()
Date: Thu, 3 Oct 2019 13:40:57 +0530 [thread overview]
Message-ID: <1570090257-25001-1-git-send-email-anshuman.khandual@arm.com> (raw)
Having unmovable pages on a given pageblock should be reported correctly
when required with REPORT_FAILURE flag. But there can be a scenario where a
reserved page in the page block will get reported as a generic "unmovable"
reason code. Instead this should be changed to a more appropriate reason
code like "Reserved page".
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Michal Hocko <mhocko@suse.com>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: Oscar Salvador <osalvador@suse.de>
Cc: Mel Gorman <mgorman@techsingularity.net>
Cc: Mike Rapoport <rppt@linux.ibm.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Pavel Tatashin <pavel.tatashin@microsoft.com>
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
mm/page_alloc.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 15c2050c629b..fbf93ea119d2 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -8206,8 +8206,10 @@ bool has_unmovable_pages(struct zone *zone, struct page *page, int count,
page = pfn_to_page(check);
- if (PageReserved(page))
+ if (PageReserved(page)) {
+ reason = "Reserved page";
goto unmovable;
+ }
/*
* If the zone is movable and we have ruled out all reserved
--
2.20.1
next reply other threads:[~2019-10-03 8:10 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-03 8:10 Anshuman Khandual [this message]
2019-10-03 9:05 ` [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages() Qian Cai
2019-10-03 9:32 ` Anshuman Khandual
2019-10-03 9:53 ` Anshuman Khandual
2019-10-03 11:19 ` Qian Cai
2019-10-03 11:32 ` Anshuman Khandual
2019-10-03 11:50 ` Qian Cai
2019-10-03 12:02 ` Anshuman Khandual
2019-10-03 12:14 ` Qian Cai
2019-10-04 8:25 ` David Hildenbrand
2020-01-14 8:19 ` Anshuman Khandual
2020-01-14 8:30 ` David Hildenbrand
2020-01-14 9:10 ` Michal Hocko
2020-01-14 10:23 ` Vlastimil Babka
2020-01-14 11:03 ` Anshuman Khandual
2020-01-14 11:32 ` Michal Hocko
2020-01-14 12:04 ` [PATCH] mm, debug: always print flags in dump_page() Vlastimil Babka
2020-01-14 13:35 ` Michal Hocko
2020-01-14 18:22 ` [PATCH] mm/page_alloc: Add a reason for reserved pages in has_unmovable_pages() Ralph Campbell
2019-10-04 10:58 ` Michal Hocko
2019-10-04 11:44 ` Anshuman Khandual
2019-10-04 12:56 ` Qian Cai
2019-10-04 13:07 ` Michal Hocko
2019-10-04 13:30 ` Qian Cai
2019-10-04 13:38 ` Michal Hocko
2019-10-04 13:56 ` Qian Cai
2019-10-04 14:41 ` Michal Hocko
2019-10-05 21:22 ` Andrew Morton
2019-10-05 22:38 ` Qian Cai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570090257-25001-1-git-send-email-anshuman.khandual@arm.com \
--to=anshuman.khandual@arm.com \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=pavel.tatashin@microsoft.com \
--cc=rppt@linux.ibm.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).