From: Geert Uytterhoeven <geert+renesas@glider.be>
To: Andy Whitcroft <apw@canonical.com>, Joe Perches <joe@perches.com>
Cc: linux-kernel@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: [PATCH] checkpatch: use patch subject when reading from stdin
Date: Tue, 8 Oct 2019 11:40:06 +0200 [thread overview]
Message-ID: <20191008094006.8251-1-geert+renesas@glider.be> (raw)
When reading a patch file from standard input, checkpatch calls it "Your
patch", and reports its state as:
Your patch has style problems, please review.
or:
Your patch has no obvious style problems and is ready for submission.
Hence when checking multiple patches by piping them to checkpatch, e.g.
when checking patchwork bundles using:
formail -s scripts/checkpatch.pl < bundle-foo.mbox
it is difficult to identify which patches need to be reviewed and
improved.
Fix this by replacing "Your patch" by the patch subject, if present.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
scripts/checkpatch.pl | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6fcc66afb0880830..6b9feb4d646a116b 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1047,6 +1047,10 @@ for my $filename (@ARGV) {
}
while (<$FILE>) {
chomp;
+ if ($vname eq 'Your patch') {
+ my ($subject) = $_ =~ /^Subject:\s*(.*)/;
+ $vname = '"' . $subject . '"' if $subject;
+ }
push(@rawlines, $_);
}
close($FILE);
--
2.17.1
next reply other threads:[~2019-10-08 9:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 9:40 Geert Uytterhoeven [this message]
2019-10-08 12:50 ` [PATCH] checkpatch: use patch subject when reading from stdin Joe Perches
2019-10-08 12:59 ` Geert Uytterhoeven
2019-10-08 15:20 ` Joe Perches
2019-10-08 15:28 ` Geert Uytterhoeven
2019-10-08 17:02 ` Joe Perches
2019-10-08 18:10 ` Geert Uytterhoeven
2019-10-08 18:25 ` Joe Perches
2019-10-08 18:39 ` Geert Uytterhoeven
2019-10-08 18:50 ` Joe Perches
2019-10-14 9:20 ` Geert Uytterhoeven
2019-10-14 14:48 ` Joe Perches
2019-10-15 6:49 ` Geert Uytterhoeven
2019-10-15 15:50 ` Joe Perches
2019-10-15 16:40 ` Geert Uytterhoeven
2019-10-15 17:24 ` Joe Perches
2019-10-16 6:57 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008094006.8251-1-geert+renesas@glider.be \
--to=geert+renesas@glider.be \
--cc=apw@canonical.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).