From: Fabrice Gasnier <fabrice.gasnier@st.com>
To: <thierry.reding@gmail.com>, <u.kleine-koenig@pengutronix.de>
Cc: <alexandre.torgue@st.com>, <benjamin.gaignard@st.com>,
<fabrice.gasnier@st.com>, <linux-pwm@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>
Subject: [PATCH] pwm: stm32: add comment to better describe breakinput feature
Date: Tue, 8 Oct 2019 13:41:27 +0200 [thread overview]
Message-ID: <1570534887-26181-1-git-send-email-fabrice.gasnier@st.com> (raw)
Add a comment to better describe the purpose of breakinput feature that
can be found on some STM32 timer instances. Briefly comment on the
characteristics of this input for PWM, and pinmuxing as suggested in [1].
[1] https://lkml.org/lkml/2019/10/1/207
Signed-off-by: Fabrice Gasnier <fabrice.gasnier@st.com>
---
drivers/pwm/pwm-stm32.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/pwm/pwm-stm32.c b/drivers/pwm/pwm-stm32.c
index 359b085..6406ebb 100644
--- a/drivers/pwm/pwm-stm32.c
+++ b/drivers/pwm/pwm-stm32.c
@@ -522,8 +522,14 @@ static int stm32_pwm_apply_breakinputs(struct stm32_pwm *priv,
sizeof(struct stm32_breakinput));
/*
+ * Some timer instances can have BRK input pins (e.g. basically a fault
+ * pin from the output power stage). The break feature allows a safe
+ * shut-down of the PWM outputs to a predefined state. Further details
+ * are available in application note AN4277, "Using STM32 device PWM
+ * shut-down features..."
* Because "st,breakinput" parameter is optional do not make probe
- * failed if it doesn't exist.
+ * failed if it doesn't exist. The pinctrl handle must hold the BRK
+ * pin(s) when using "st,breakinput" property.
*/
if (nb <= 0)
return 0;
--
2.7.4
next reply other threads:[~2019-10-08 11:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-08 11:41 Fabrice Gasnier [this message]
2019-10-08 14:45 ` [PATCH] pwm: stm32: add comment to better describe breakinput feature Uwe Kleine-König
2019-10-09 9:51 ` Fabrice Gasnier
2019-10-10 7:07 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570534887-26181-1-git-send-email-fabrice.gasnier@st.com \
--to=fabrice.gasnier@st.com \
--cc=alexandre.torgue@st.com \
--cc=benjamin.gaignard@st.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).