From: Jean-Jacques Hiblot <jjhiblot@ti.com>
To: <jacek.anaszewski@gmail.com>, <pavel@ucw.cz>, <sre@kernel.org>,
<robh+dt@kernel.org>, <mark.rutland@arm.com>,
<lee.jones@linaro.org>, <daniel.thompson@linaro.org>
Cc: <dmurphy@ti.com>, <linux-leds@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
<tomi.valkeinen@ti.com>, Jean-Jacques Hiblot <jjhiblot@ti.com>,
<devicetree@vger.kernel.org>
Subject: [PATCH v10 4/6] dts-bindings: leds: Document the naming requirement for LED properties
Date: Wed, 9 Oct 2019 10:51:25 +0200 [thread overview]
Message-ID: <20191009085127.22843-5-jjhiblot@ti.com> (raw)
In-Reply-To: <20191009085127.22843-1-jjhiblot@ti.com>
LED properties must be named "leds" in the same way that PWM, clocks or
PHY properties are names respectively "pwms", "clocks" and "phys".
Cc: devicetree@vger.kernel.org
Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
---
.../devicetree/bindings/leds/common.txt | 20 ++++++++++++++++---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/Documentation/devicetree/bindings/leds/common.txt b/Documentation/devicetree/bindings/leds/common.txt
index 9fa6f9795d50..31b8c1f68d27 100644
--- a/Documentation/devicetree/bindings/leds/common.txt
+++ b/Documentation/devicetree/bindings/leds/common.txt
@@ -10,6 +10,9 @@ can influence the way of the LED device initialization, the LED components
have to be tightly coupled with the LED device binding. They are represented
by child nodes of the parent LED device binding.
+LED properties should be named "leds". The exact meaning of each leds
+property must be documented in the device tree binding for each device.
+
Optional properties for child nodes:
- led-sources : List of device current outputs the LED is connected to. The
@@ -165,9 +168,20 @@ led-controller@30 {
function-enumerator = <2>;
};
- led@3 {
+ bkl_led0: led@3 {
reg = <3>;
- function = LED_FUNCTION_INDICATOR;
- function-enumerator = <3>;
+ function = LED_FUNCTION_BACKLIGHT;
+ function-enumerator = <1>;
};
+
+ bkl_led1: led@4 {
+ reg = <4>;
+ function = LED_FUNCTION_BACKLIGHT;
+ function-enumerator = <2>;
+ };
+};
+
+
+backlight@40 {
+ leds = <&bkl_led0> , <&bkl_led1>;
};
--
2.17.1
next prev parent reply other threads:[~2019-10-09 8:52 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 8:51 [PATCH v10 0/6] Add a generic driver for LED-based backlight Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 1/6] leds: populate the device's of_node Jean-Jacques Hiblot
2019-10-09 10:52 ` Tomi Valkeinen
2019-10-09 8:51 ` [PATCH v10 2/6] leds: Add of_led_get() and led_put() Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 3/6] leds: Add managed API to get a LED from a device driver Jean-Jacques Hiblot
2019-10-09 8:51 ` Jean-Jacques Hiblot [this message]
2019-10-09 19:26 ` [PATCH v10 4/6] dts-bindings: leds: Document the naming requirement for LED properties Rob Herring
2019-10-10 10:31 ` Jean-Jacques Hiblot
2019-10-09 8:51 ` [PATCH v10 5/6] dt-bindings: backlight: Add led-backlight binding Jean-Jacques Hiblot
2019-10-09 19:35 ` Rob Herring
2019-11-21 18:22 ` Tony Lindgren
2019-10-09 8:51 ` [PATCH v10 6/6] backlight: add led-backlight driver Jean-Jacques Hiblot
2019-11-21 18:13 ` Tony Lindgren
2020-01-07 10:28 ` Lee Jones
2020-01-07 13:45 ` Pavel Machek
2020-01-07 14:33 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009085127.22843-5-jjhiblot@ti.com \
--to=jjhiblot@ti.com \
--cc=daniel.thompson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).