From: YueHaibing <yuehaibing@huawei.com>
To: Andrea Arcangeli <aarcange@redhat.com>,
"Joel Fernandes (Google)" <joel@joelfernandes.org>,
Andrew Morton <akpm@linux-foundation.org>,
"Mike Kravetz" <mike.kravetz@oracle.com>,
Stephen Rothwell <sfr@canb.auug.org.au>,
Wei Yang <richardw.yang@linux.intel.com>,
Hugh Dickins <hughd@google.com>
Cc: YueHaibing <yuehaibing@huawei.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: [PATCH -next] userfaultfd: remove set but not used variable 'h'
Date: Wed, 9 Oct 2019 12:27:40 +0000 [thread overview]
Message-ID: <20191009122740.70517-1-yuehaibing@huawei.com> (raw)
Fixes gcc '-Wunused-but-set-variable' warning:
mm/userfaultfd.c: In function '__mcopy_atomic_hugetlb':
mm/userfaultfd.c:217:17: warning:
variable 'h' set but not used [-Wunused-but-set-variable]
It is not used since commit 78911d0e18ac ("userfaultfd: use vma_pagesize
for all huge page size calculation")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
mm/userfaultfd.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/mm/userfaultfd.c b/mm/userfaultfd.c
index 4cb4ef3d9128..1b0d7abad1d4 100644
--- a/mm/userfaultfd.c
+++ b/mm/userfaultfd.c
@@ -214,7 +214,6 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm,
unsigned long src_addr, dst_addr;
long copied;
struct page *page;
- struct hstate *h;
unsigned long vma_hpagesize;
pgoff_t idx;
u32 hash;
@@ -271,8 +270,6 @@ static __always_inline ssize_t __mcopy_atomic_hugetlb(struct mm_struct *dst_mm,
goto out_unlock;
}
- h = hstate_vma(dst_vma);
-
while (src_addr < src_start + len) {
pte_t dst_pteval;
next reply other threads:[~2019-10-09 12:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 12:27 YueHaibing [this message]
2019-10-10 0:45 ` [PATCH -next] userfaultfd: remove set but not used variable 'h' Mike Kravetz
2019-10-10 1:23 ` Wei Yang
2019-10-10 2:25 ` Mike Kravetz
2019-10-10 3:30 ` Wei Yang
2019-10-10 3:42 ` Mike Kravetz
2019-10-10 3:53 ` Wei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191009122740.70517-1-yuehaibing@huawei.com \
--to=yuehaibing@huawei.com \
--cc=aarcange@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hughd@google.com \
--cc=joel@joelfernandes.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mike.kravetz@oracle.com \
--cc=richardw.yang@linux.intel.com \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).