From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
To: linux-kernel@vger.kernel.org
Cc: hch@infradead.org,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
linux-sh@vger.kernel.org
Subject: [PATCH] sh: use dma_to_phys() instead of dev->dma_pfn_offset
Date: Fri, 11 Oct 2019 18:51:29 +0200 [thread overview]
Message-ID: <20191011165129.29655-1-nsaenzjulienne@suse.de> (raw)
It's more explicit and lets dma-direct handle the specifics of how to
translate addresses.
On top of that get rid of warnings as, since the introduction of commit
6fa1d28e38c ("sh: use generic dma_noncoherent_ops"), it's impossible for
the dev to be NULL.
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
NOTE: this was only compile tested.
arch/sh/kernel/dma-coherent.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/arch/sh/kernel/dma-coherent.c b/arch/sh/kernel/dma-coherent.c
index b17514619b7e..f6618ed01a42 100644
--- a/arch/sh/kernel/dma-coherent.c
+++ b/arch/sh/kernel/dma-coherent.c
@@ -4,6 +4,7 @@
*/
#include <linux/mm.h>
#include <linux/init.h>
+#include <linux/dma-direct.h>
#include <linux/dma-noncoherent.h>
#include <linux/module.h>
#include <asm/cacheflush.h>
@@ -36,9 +37,7 @@ void *arch_dma_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle,
split_page(pfn_to_page(virt_to_phys(ret) >> PAGE_SHIFT), order);
- *dma_handle = virt_to_phys(ret);
- if (!WARN_ON(!dev))
- *dma_handle -= PFN_PHYS(dev->dma_pfn_offset);
+ *dma_handle = phys_to_dma(dev, virt_to_phys(ret));
return ret_nocache;
}
@@ -47,12 +46,9 @@ void arch_dma_free(struct device *dev, size_t size, void *vaddr,
dma_addr_t dma_handle, unsigned long attrs)
{
int order = get_order(size);
- unsigned long pfn = (dma_handle >> PAGE_SHIFT);
+ unsigned long pfn = __phys_to_pfn(dma_to_phys(dev, dma_handle));
int k;
- if (!WARN_ON(!dev))
- pfn += dev->dma_pfn_offset;
-
for (k = 0; k < (1 << order); k++)
__free_pages(pfn_to_page(pfn + k), 0);
--
2.23.0
next reply other threads:[~2019-10-11 16:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-11 16:51 Nicolas Saenz Julienne [this message]
2019-10-15 7:43 ` [PATCH] sh: use dma_to_phys() instead of dev->dma_pfn_offset Christoph Hellwig
2019-10-15 8:05 ` Nicolas Saenz Julienne
2019-10-15 9:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011165129.29655-1-nsaenzjulienne@suse.de \
--to=nsaenzjulienne@suse.de \
--cc=dalias@libc.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).