From: zhong jiang <zhongjiang@huawei.com>
To: <gregkh@linuxfoundation.org>
Cc: <Jerome.Pouiller@silabs.com>, <linux-kernel@vger.kernel.org>
Subject: [PATCH v3] staging: wfx: fix an undefined reference error when CONFIG_MMC=m
Date: Sat, 12 Oct 2019 18:54:53 +0800 [thread overview]
Message-ID: <1570877693-52711-1-git-send-email-zhongjiang@huawei.com> (raw)
I hit the following error when compile the kernel.
drivers/staging/wfx/main.o: In function `wfx_core_init':
/home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:488: undefined reference to `sdio_register_driver'
drivers/staging/wfx/main.o: In function `wfx_core_exit':
/home/z00352263/linux-next/linux-next/drivers/staging/wfx/main.c:496: undefined reference to `sdio_unregister_driver'
drivers/staging/wfx/main.o:(.debug_addr+0x1a8): undefined reference to `sdio_register_driver'
drivers/staging/wfx/main.o:(.debug_addr+0x6f0): undefined reference to `sdio_unregister_driver'
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
v2->v3:
We'd better not use #ifdef in .c file to use IS_ENABLED instead.
v1->v2:
We should prefer to current dependencies rather than force to enable.
drivers/staging/wfx/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/Makefile b/drivers/staging/wfx/Makefile
index 0d9c1ed..77d68b7 100644
--- a/drivers/staging/wfx/Makefile
+++ b/drivers/staging/wfx/Makefile
@@ -19,6 +19,6 @@ wfx-y := \
sta.o \
debug.o
wfx-$(CONFIG_SPI) += bus_spi.o
-wfx-$(subst m,y,$(CONFIG_MMC)) += bus_sdio.o
+wfx-$(CONFIG_MMC) += bus_sdio.o
obj-$(CONFIG_WFX) += wfx.o
--
1.7.12.4
next reply other threads:[~2019-10-12 10:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-12 10:54 zhong jiang [this message]
2019-10-12 15:32 ` [PATCH v3] staging: wfx: fix an undefined reference error when CONFIG_MMC=m Greg KH
2019-10-13 14:17 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1570877693-52711-1-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=Jerome.Pouiller@silabs.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).