[v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
diff mbox series

Message ID 20191013185643.GA2583@localhost.localdomain
State Accepted
Commit 0b6b30c65621fc11a799ca71241f52d8fd9e334c
Headers show
Series
  • [v1] Ask user input only when CONFIG_X86 or CONFIG_COMPILE_TEST is set to y
Related show

Commit Message

Narendra.K@dell.com Oct. 13, 2019, 6:57 p.m. UTC
From: Narendra K <Narendra.K@dell.com>

For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
for input on platforms where the option may not be applicable. This patch
modifies the kconfig option to ask the user for input only when CONFIG_X86
or CONFIG_COMPILE_TEST is set to y.

Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Narendra K <Narendra.K@dell.com>
---
 drivers/firmware/efi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Narendra.K@dell.com Oct. 13, 2019, 7:15 p.m. UTC | #1
Hi Ard,

On Sun, Oct 13, 2019 at 06:57:05PM +0000, K, Narendra wrote:
> From: Narendra K <Narendra.K@dell.com>
> 
> For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> for input on platforms where the option may not be applicable. This patch
> modifies the kconfig option to ask the user for input only when CONFIG_X86
> or CONFIG_COMPILE_TEST is set to y.
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Signed-off-by: Narendra K <Narendra.K@dell.com>
> ---
I missed mentioning the following details -

This patch is created on kernel version 5.4-rc2

Changes in v1:
- dropped following changes
	'depends on EFI' as it is implied
	'default n' as 'n' is the default if not mentioned
	splitting 'bool' to 'bool + prompt'
- added dependency on X86 || COMPILE_TEST
- added the 'Reported-by:' and 'Fix-suggested-by:' to give credit to 
Geert Uytterhoeven who reported the issue and suggested the fix 


>  drivers/firmware/efi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
> index 178ee8106828..b248870a9806 100644
> --- a/drivers/firmware/efi/Kconfig
> +++ b/drivers/firmware/efi/Kconfig
> @@ -182,6 +182,7 @@ config RESET_ATTACK_MITIGATION
>  
>  config EFI_RCI2_TABLE
>  	bool "EFI Runtime Configuration Interface Table Version 2 Support"
> +	depends on X86 || COMPILE_TEST
>  	help
>  	  Displays the content of the Runtime Configuration Interface
>  	  Table version 2 on Dell EMC PowerEdge systems as a binary
> -- 
> 2.18.1
> 
> -- 
> With regards,
> Narendra K
Geert Uytterhoeven Oct. 14, 2019, 6:41 a.m. UTC | #2
Hi Narendra,

On Sun, Oct 13, 2019 at 8:57 PM <Narendra.K@dell.com> wrote:
> From: Narendra K <Narendra.K@dell.com>
>
> For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> for input on platforms where the option may not be applicable. This patch
> modifies the kconfig option to ask the user for input only when CONFIG_X86
> or CONFIG_COMPILE_TEST is set to y.
>
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>

Suggested-by: ...?

> Signed-off-by: Narendra K <Narendra.K@dell.com>

Thanks for your patch!

Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert
Ard Biesheuvel Oct. 14, 2019, 6:49 a.m. UTC | #3
On Mon, 14 Oct 2019 at 08:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Narendra,
>
> On Sun, Oct 13, 2019 at 8:57 PM <Narendra.K@dell.com> wrote:
> > From: Narendra K <Narendra.K@dell.com>
> >
> > For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> > for input on platforms where the option may not be applicable. This patch
> > modifies the kconfig option to ask the user for input only when CONFIG_X86
> > or CONFIG_COMPILE_TEST is set to y.
> >
> > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> Suggested-by: ...?
>

Indeed

> > Signed-off-by: Narendra K <Narendra.K@dell.com>
>
> Thanks for your patch!
>
> Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
>

Thanks all. I'll get this queued as a fix.
Narendra.K@dell.com Oct. 14, 2019, 9:51 a.m. UTC | #4
On Mon, Oct 14, 2019 at 08:49:51AM +0200, Ard Biesheuvel wrote:
> 
> [EXTERNAL EMAIL] 
> 
> On Mon, 14 Oct 2019 at 08:41, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
> >
> > Hi Narendra,
> >
> > On Sun, Oct 13, 2019 at 8:57 PM <Narendra.K@dell.com> wrote:
> > > From: Narendra K <Narendra.K@dell.com>
> > >
> > > For the EFI_RCI2_TABLE kconfig option, 'make oldconfig' asks the user
> > > for input on platforms where the option may not be applicable. This patch
> > > modifies the kconfig option to ask the user for input only when CONFIG_X86
> > > or CONFIG_COMPILE_TEST is set to y.
> > >
> > > Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Fix-suggested-by: Geert Uytterhoeven <geert@linux-m68k.org>
> >
> > Suggested-by: ...?
> >
> 
> Indeed

Hi Ard/Geert,

Thank you for correcting this. Should the patch be resubmitted with
the above change made ?

> 
> > > Signed-off-by: Narendra K <Narendra.K@dell.com>
> >
> > Thanks for your patch!
> >
> > Tested-by: Geert Uytterhoeven <geert+renesas@glider.be>
> >
> 
> Thanks all. I'll get this queued as a fix.

Thank you for review comments.

Patch
diff mbox series

diff --git a/drivers/firmware/efi/Kconfig b/drivers/firmware/efi/Kconfig
index 178ee8106828..b248870a9806 100644
--- a/drivers/firmware/efi/Kconfig
+++ b/drivers/firmware/efi/Kconfig
@@ -182,6 +182,7 @@  config RESET_ATTACK_MITIGATION
 
 config EFI_RCI2_TABLE
 	bool "EFI Runtime Configuration Interface Table Version 2 Support"
+	depends on X86 || COMPILE_TEST
 	help
 	  Displays the content of the Runtime Configuration Interface
 	  Table version 2 on Dell EMC PowerEdge systems as a binary