ISDN multichannel crash
diff mbox series

Message ID 20021116001507.GA17915@gondor.apana.org.au
State New, archived
Headers show
Series
  • ISDN multichannel crash
Related show

Commit Message

Herbert Xu Nov. 16, 2002, 12:15 a.m. UTC 
If you get the message

isdn_ppp_xmit: lp->ppp_slot -1

and your system crashes immediately afterwards, then this patch is for you.
The xmit_lock isn't released when this happens which leaves BH disabled.

The same fix is needed in 2.2 as well.

Patch
diff mbox series 

Index: drivers/isdn/isdn_ppp.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.4/drivers/isdn/isdn_ppp.c,v
retrieving revision 1.1.1.14
diff -u -r1.1.1.14 isdn_ppp.c
--- drivers/isdn/isdn_ppp.c	3 Aug 2002 00:39:44 -0000	1.1.1.14
+++ drivers/isdn/isdn_ppp.c	16 Nov 2002 00:10:18 -0000
@@ -1147,7 +1147,7 @@ 
 	if (slot < 0 || slot > ISDN_MAX_CHANNELS) {
 		printk(KERN_ERR "isdn_ppp_xmit: lp->ppp_slot %d\n", lp->ppp_slot);
 		kfree_skb(skb);
-		return 0;
+		goto unlock;
 	}
 	ipt = ippp_table[slot];
 	lp->huptimer = 0;