From: Herbert Xu <herbert@gondor.apana.org.au>
To: kai.germaschewski@gmx.de
Cc: marcelo@conectiva.com.br, Alan Cox <alan@lxorguk.ukuu.org.uk>,
linux-kernel@vger.kernel.org
Subject: [PATCH] ISDN multichannel crash
Date: Sat, 16 Nov 2002 11:15:07 +1100 [thread overview]
Message-ID: <20021116001507.GA17915@gondor.apana.org.au> (raw)
[-- Attachment #1: Type: text/plain, Size: 469 bytes --]
If you get the message
isdn_ppp_xmit: lp->ppp_slot -1
and your system crashes immediately afterwards, then this patch is for you.
The xmit_lock isn't released when this happens which leaves BH disabled.
The same fix is needed in 2.2 as well.
--
Debian GNU/Linux 3.0 is out! ( http://www.debian.org/ )
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
[-- Attachment #2: p --]
[-- Type: text/plain, Size: 604 bytes --]
Index: drivers/isdn/isdn_ppp.c
===================================================================
RCS file: /home/gondolin/herbert/src/CVS/debian/kernel-source-2.4/drivers/isdn/isdn_ppp.c,v
retrieving revision 1.1.1.14
diff -u -r1.1.1.14 isdn_ppp.c
--- drivers/isdn/isdn_ppp.c 3 Aug 2002 00:39:44 -0000 1.1.1.14
+++ drivers/isdn/isdn_ppp.c 16 Nov 2002 00:10:18 -0000
@@ -1147,7 +1147,7 @@
if (slot < 0 || slot > ISDN_MAX_CHANNELS) {
printk(KERN_ERR "isdn_ppp_xmit: lp->ppp_slot %d\n", lp->ppp_slot);
kfree_skb(skb);
- return 0;
+ goto unlock;
}
ipt = ippp_table[slot];
lp->huptimer = 0;
reply other threads:[~2002-11-16 0:09 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20021116001507.GA17915@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=kai.germaschewski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).