[v3,7/8] riscv: fp: add missing __user pointer annotations
diff mbox series

Message ID 20191018080841.26712-8-paul.walmsley@sifive.com
State In Next
Commit 26c19bbeb4e865bc7581db6ad1f23044e78236e5
Headers show
  • riscv: resolve most warnings from sparse
Related show

Commit Message

Paul Walmsley Oct. 18, 2019, 8:08 a.m. UTC
The __user annotations were removed from the {save,restore}_fp_state()
function signatures by commit 007f5c358957 ("Refactor FPU code in
signal setup/return procedures"), but should be present, and sparse
warns when they are not applied.  Add them back in.

This change should have no functional impact.

Signed-off-by: Paul Walmsley <paul.walmsley@sifive.com>
Fixes: 007f5c358957 ("Refactor FPU code in signal setup/return procedures")
Cc: Alan Kao <alankao@andestech.com>
 arch/riscv/kernel/signal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)


Christoph Hellwig Oct. 18, 2019, 3:56 p.m. UTC | #1
Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>

diff mbox series

diff --git a/arch/riscv/kernel/signal.c b/arch/riscv/kernel/signal.c
index 85c700ad47e9..9437167f463e 100644
--- a/arch/riscv/kernel/signal.c
+++ b/arch/riscv/kernel/signal.c
@@ -28,7 +28,7 @@  struct rt_sigframe {
 #ifdef CONFIG_FPU
 static long restore_fp_state(struct pt_regs *regs,
-			     union __riscv_fp_state *sc_fpregs)
+			     union __riscv_fp_state __user *sc_fpregs)
 	long err;
 	struct __riscv_d_ext_state __user *state = &sc_fpregs->d;
@@ -55,7 +55,7 @@  static long restore_fp_state(struct pt_regs *regs,
 static long save_fp_state(struct pt_regs *regs,
-			  union __riscv_fp_state *sc_fpregs)
+			  union __riscv_fp_state __user *sc_fpregs)
 	long err;
 	struct __riscv_d_ext_state __user *state = &sc_fpregs->d;