From: Huazhong Tan <tanhuazhong@huawei.com>
To: <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<salil.mehta@huawei.com>, <yisen.zhuang@huawei.com>,
<linuxarm@huawei.com>, <jakub.kicinski@netronome.com>,
Yunsheng Lin <linyunsheng@huawei.com>,
Huazhong Tan <tanhuazhong@huawei.com>
Subject: [PATCH net-next 7/8] net: hns3: do not allocate linear data for fraglist skb
Date: Sat, 19 Oct 2019 16:03:55 +0800 [thread overview]
Message-ID: <1571472236-17401-8-git-send-email-tanhuazhong@huawei.com> (raw)
In-Reply-To: <1571472236-17401-1-git-send-email-tanhuazhong@huawei.com>
From: Yunsheng Lin <linyunsheng@huawei.com>
Currently, napi_alloc_skb() is used to allocate skb for fraglist
when the head skb is not enough to hold the remaining data, and
the remaining data is added to the frags part of the fraglist skb,
leaving the linear part unused.
So this patch passes length of 0 to allocate fraglist skb with
zero size of linear data.
Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
---
drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
index 1c5e0d2..0fdd684 100644
--- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
+++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c
@@ -2863,8 +2863,7 @@ static int hns3_add_frag(struct hns3_enet_ring *ring, struct hns3_desc *desc,
return -ENXIO;
if (unlikely(ring->frag_num >= MAX_SKB_FRAGS)) {
- new_skb = napi_alloc_skb(&ring->tqp_vector->napi,
- HNS3_RX_HEAD_SIZE);
+ new_skb = napi_alloc_skb(&ring->tqp_vector->napi, 0);
if (unlikely(!new_skb)) {
hns3_rl_err(ring_to_netdev(ring),
"alloc rx fraglist skb fail\n");
--
2.7.4
next prev parent reply other threads:[~2019-10-19 8:03 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-19 8:03 [PATCH net-next 0/8] net: hns3: add some cleanups & optimizations Huazhong Tan
2019-10-19 8:03 ` [PATCH net-next 1/8] net: hns3: remove struct hns3_nic_ring_data in hns3_enet module Huazhong Tan
2019-10-19 8:03 ` [PATCH net-next 2/8] net: hns3: optimized MAC address in management table Huazhong Tan
2019-10-19 8:03 ` [PATCH net-next 3/8] net: hns3: minor optimization for barrier in IO path Huazhong Tan
2019-10-19 8:03 ` [PATCH net-next 4/8] net: hns3: introduce ring_to_netdev() in enet module Huazhong Tan
2019-10-19 8:03 ` [PATCH net-next 5/8] net: hns3: make struct hns3_enet_ring cacheline aligned Huazhong Tan
2019-10-19 8:03 ` [PATCH net-next 6/8] net: hns3: minor cleanup for hns3_handle_rx_bd() Huazhong Tan
2019-10-19 8:03 ` Huazhong Tan [this message]
2019-10-19 8:03 ` [PATCH net-next 8/8] net: hns3: log and clear hardware error after reset complete Huazhong Tan
2019-10-20 17:37 ` [PATCH net-next 0/8] net: hns3: add some cleanups & optimizations Jakub Kicinski
2019-10-21 16:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1571472236-17401-8-git-send-email-tanhuazhong@huawei.com \
--to=tanhuazhong@huawei.com \
--cc=davem@davemloft.net \
--cc=jakub.kicinski@netronome.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=linyunsheng@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).