From: Florian Fainelli <f.fainelli@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: bcm-kernel-feedback-list@broadcom.com,
Florian Fainelli <f.fainelli@gmail.com>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Cooper <jason@lakedaemon.net>,
Marc Zyngier <maz@kernel.org>
Subject: [PATCH] irqchip/gic: Check interrupt type validity
Date: Wed, 23 Oct 2019 12:56:19 -0700 [thread overview]
Message-ID: <20191023195620.23415-1-f.fainelli@gmail.com> (raw)
In case the interrupt property specifies a type parameter that is not
GIC_SPI (0) or GIC_PPIC (1), do not attempt to translate the interrupt
and return -EINVAL instead.
Fixes: f833f57ff254 ("irqchip: Convert all alloc/xlate users from of_node to fwnode")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
Marc,
Regardless of whether my attempt to use SGI moves any further, this
seems appropriate to do since we should not be trying to translate
incorrectly specified interrupts. Thanks!
drivers/irqchip/irq-gic.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/irqchip/irq-gic.c b/drivers/irqchip/irq-gic.c
index 30ab623343d3..fc47e655618d 100644
--- a/drivers/irqchip/irq-gic.c
+++ b/drivers/irqchip/irq-gic.c
@@ -1005,6 +1005,9 @@ static int gic_irq_domain_translate(struct irq_domain *d,
if (fwspec->param_count < 3)
return -EINVAL;
+ if (fwspec->param[0] > 1)
+ return -EINVAL;
+
/* Get the interrupt number and add 16 to skip over SGIs */
*hwirq = fwspec->param[1] + 16;
--
2.17.1
next reply other threads:[~2019-10-23 19:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-23 19:56 Florian Fainelli [this message]
2019-11-15 22:32 ` [PATCH] irqchip/gic: Check interrupt type validity Florian Fainelli
2019-11-16 13:35 ` Marc Zyngier
2019-12-10 20:25 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191023195620.23415-1-f.fainelli@gmail.com \
--to=f.fainelli@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=jason@lakedaemon.net \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).