From: Saurav Girepunje <saurav.girepunje@gmail.com>
To: linux@armlinux.org.uk, joern@lazybastard.org,
dwmw2@infradead.org, computersforpeace@gmail.com,
marek.vasut@gmail.com, miquel.raynal@bootlin.com, richard@nod.at,
vigneshr@ti.com, saurav.girepunje@gmail.com,
gregkh@linuxfoundation.org, tglx@linutronix.de,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Cc: saurav.girepunje@hotmail.com
Subject: [PATCH] mtd: devices: phram.c: Fix use true/false for bool type
Date: Tue, 29 Oct 2019 08:51:42 +0530 [thread overview]
Message-ID: <20191029032142.GA6758@saurav> (raw)
Return type for security_extensions_enabled() is bool
so use true/false.
Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
---
arch/arm/mm/nommu.c | 2 +-
drivers/mtd/devices/phram.c | 11 +++++------
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/arch/arm/mm/nommu.c b/arch/arm/mm/nommu.c
index 24ecf8d30a1e..1fed74f93c66 100644
--- a/arch/arm/mm/nommu.c
+++ b/arch/arm/mm/nommu.c
@@ -56,7 +56,7 @@ static inline bool security_extensions_enabled(void)
if ((read_cpuid_id() & 0x000f0000) == 0x000f0000)
return cpuid_feature_extract(CPUID_EXT_PFR1, 4) ||
cpuid_feature_extract(CPUID_EXT_PFR1, 20);
- return 0;
+ return true;
}
unsigned long setup_vectors_base(void)
diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c
index 86ae13b756b5..931e5c2481b5 100644
--- a/drivers/mtd/devices/phram.c
+++ b/drivers/mtd/devices/phram.c
@@ -239,27 +239,26 @@ static int phram_setup(const char *val)
ret = parse_name(&name, token[0]);
if (ret)
- goto exit;
+ return ret;
ret = parse_num64(&start, token[1]);
if (ret) {
+ kfree(name);
parse_err("illegal start address\n");
- goto parse_err;
}
ret = parse_num64(&len, token[2]);
if (ret) {
+ kfree(name);
parse_err("illegal device length\n");
- goto parse_err;
}
ret = register_device(name, start, len);
if (!ret)
pr_info("%s device: %#llx at %#llx\n", name, len, start);
+ else
+ kfree(name);
-parse_err:
- kfree(name);
-exit:
return ret;
}
--
2.20.1
next reply other threads:[~2019-10-29 3:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 3:21 Saurav Girepunje [this message]
2019-10-29 9:14 ` [PATCH] mtd: devices: phram.c: Fix use true/false for bool type Russell King - ARM Linux admin
2019-10-29 14:00 ` SAURAV GIREPUNJE
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191029032142.GA6758@saurav \
--to=saurav.girepunje@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=gregkh@linuxfoundation.org \
--cc=joern@lazybastard.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=marek.vasut@gmail.com \
--cc=miquel.raynal@bootlin.com \
--cc=richard@nod.at \
--cc=saurav.girepunje@hotmail.com \
--cc=tglx@linutronix.de \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).