From: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
To: Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, Theodore Ts'o <tytso@mit.edu>,
linux-kernel@vger.kernel.org
Cc: Dmitry Monakhov <dmtrmonakhov@yandex-team.ru>,
Eric Whitney <enwlinux@gmail.com>
Subject: [PATCH] ext4: deaccount delayed allocations at freeing inode in ext4_evict_inode()
Date: Tue, 29 Oct 2019 10:17:28 +0300 [thread overview]
Message-ID: <157233344808.4027.17162642259754563372.stgit@buzz> (raw)
If inode->i_blocks is zero then ext4_evict_inode() skips ext4_truncate().
Delayed allocation extents are freed later in ext4_clear_inode() but this
happens when quota reference is already dropped. This leads to leak of
reserved space in quota block, which disappears after umount-mount.
This seems broken for a long time but worked somehow until recent changes
in delayed allocation.
Signed-off-by: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>
---
fs/ext4/inode.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 516faa280ced..580898145e8f 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -293,6 +293,15 @@ void ext4_evict_inode(struct inode *inode)
inode->i_ino, err);
goto stop_handle;
}
+ } else if (EXT4_I(inode)->i_reserved_data_blocks) {
+ /* Deaccount reserve if inode has only delayed allocations. */
+ err = ext4_es_remove_extent(inode, 0, EXT_MAX_BLOCKS);
+ if (err) {
+ ext4_warning(inode->i_sb,
+ "couldn't remove extents %lu (err %d)",
+ inode->i_ino, err);
+ goto stop_handle;
+ }
}
/* Remove xattr references. */
next reply other threads:[~2019-10-29 7:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 7:17 Konstantin Khlebnikov [this message]
2019-10-29 7:20 ` [PATCH] ext4: deaccount delayed allocations at freeing inode in ext4_evict_inode() Konstantin Khlebnikov
2019-11-07 17:58 ` Konstantin Khlebnikov
2019-11-08 2:08 ` Ritesh Harjani
2019-11-08 8:30 ` Konstantin Khlebnikov
2019-11-08 11:54 ` Jan Kara
2019-11-15 0:27 ` Theodore Y. Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=157233344808.4027.17162642259754563372.stgit@buzz \
--to=khlebnikov@yandex-team.ru \
--cc=adilger.kernel@dilger.ca \
--cc=dmtrmonakhov@yandex-team.ru \
--cc=enwlinux@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).