From: zhong jiang <zhongjiang@huawei.com>
To: <peterz@infradead.org>, <tglx@linutronix.de>, <mingo@redhat.com>
Cc: <dave.hansen@linux.intel.com>, <bp@alien8.de>, <hpa@zytor.com>,
<zhongjiang@huawei.com>, <x86@kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] mm/ioremap: Use WARN_ONCE instead of printk() + WARN_ON_ONCE()
Date: Wed, 30 Oct 2019 16:57:18 +0800 [thread overview]
Message-ID: <1572425838-39158-1-git-send-email-zhongjiang@huawei.com> (raw)
WARN_ONCE is more clear and simpler. Just replace it.
Signed-off-by: zhong jiang <zhongjiang@huawei.com>
---
arch/x86/mm/ioremap.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/x86/mm/ioremap.c b/arch/x86/mm/ioremap.c
index a39dcdb..3b74599 100644
--- a/arch/x86/mm/ioremap.c
+++ b/arch/x86/mm/ioremap.c
@@ -172,9 +172,8 @@ static void __ioremap_check_mem(resource_size_t addr, unsigned long size,
return NULL;
if (!phys_addr_valid(phys_addr)) {
- printk(KERN_WARNING "ioremap: invalid physical address %llx\n",
- (unsigned long long)phys_addr);
- WARN_ON_ONCE(1);
+ WARN_ONCE(1, "ioremap: invalid physical address %llx\n",
+ (unsigned long long)phys_addr);
return NULL;
}
--
1.7.12.4
next reply other threads:[~2019-10-30 9:01 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 8:57 zhong jiang [this message]
2019-10-31 11:03 ` [PATCH] mm/ioremap: Use WARN_ONCE instead of printk() + WARN_ON_ONCE() Borislav Petkov
2019-10-31 11:36 ` zhong jiang
2019-10-31 12:00 ` Joe Perches
2019-10-31 12:40 ` zhong jiang
2019-11-01 15:18 ` zhong jiang
2019-10-31 11:54 ` zhong jiang
2019-10-31 15:49 ` Borislav Petkov
2019-10-31 15:54 ` zhong jiang
2019-11-01 8:45 ` Borislav Petkov
2019-11-01 15:32 ` zhong jiang
2019-11-01 16:03 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572425838-39158-1-git-send-email-zhongjiang@huawei.com \
--to=zhongjiang@huawei.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).