From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <lars@metafoo.de>, <Michael.Hennerich@analog.com>,
<jic23@kernel.org>, <dragos.bogdan@analog.com>,
Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: [PATCH 02/10] iio: imu: adis16400: check ret val for non-zero vs less-than-zero
Date: Fri, 1 Nov 2019 11:34:57 +0200 [thread overview]
Message-ID: <20191101093505.9408-3-alexandru.ardelean@analog.com> (raw)
In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com>
The ADIS library functions return zero on success, and negative values for
error. Positive values aren't returned, but we only care about the success
value (which is zero).
This change is mostly needed so that the compiler won't make any inferences
about some about values being potentially un-initialized. This only
triggers after making some functions inline, because the compiler can
better follow return paths.
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
drivers/iio/imu/adis16400.c | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/drivers/iio/imu/adis16400.c b/drivers/iio/imu/adis16400.c
index 0575ff706bd4..44e46dc96e00 100644
--- a/drivers/iio/imu/adis16400.c
+++ b/drivers/iio/imu/adis16400.c
@@ -217,16 +217,16 @@ static ssize_t adis16400_show_serial_number(struct file *file,
int ret;
ret = adis_read_reg_16(&st->adis, ADIS16334_LOT_ID1, &lot1);
- if (ret < 0)
+ if (ret)
return ret;
ret = adis_read_reg_16(&st->adis, ADIS16334_LOT_ID2, &lot2);
- if (ret < 0)
+ if (ret)
return ret;
ret = adis_read_reg_16(&st->adis, ADIS16334_SERIAL_NUMBER,
&serial_number);
- if (ret < 0)
+ if (ret)
return ret;
len = snprintf(buf, sizeof(buf), "%.4x-%.4x-%.4x\n", lot1, lot2,
@@ -249,7 +249,7 @@ static int adis16400_show_product_id(void *arg, u64 *val)
int ret;
ret = adis_read_reg_16(&st->adis, ADIS16400_PRODUCT_ID, &prod_id);
- if (ret < 0)
+ if (ret)
return ret;
*val = prod_id;
@@ -266,7 +266,7 @@ static int adis16400_show_flash_count(void *arg, u64 *val)
int ret;
ret = adis_read_reg_16(&st->adis, ADIS16400_FLASH_CNT, &flash_count);
- if (ret < 0)
+ if (ret)
return ret;
*val = flash_count;
@@ -327,7 +327,7 @@ static int adis16334_get_freq(struct adis16400_state *st)
uint16_t t;
ret = adis_read_reg_16(&st->adis, ADIS16400_SMPL_PRD, &t);
- if (ret < 0)
+ if (ret)
return ret;
t >>= ADIS16334_RATE_DIV_SHIFT;
@@ -359,7 +359,7 @@ static int adis16400_get_freq(struct adis16400_state *st)
uint16_t t;
ret = adis_read_reg_16(&st->adis, ADIS16400_SMPL_PRD, &t);
- if (ret < 0)
+ if (ret)
return ret;
sps = (t & ADIS16400_SMPL_PRD_TIME_BASE) ? 52851 : 1638404;
@@ -416,7 +416,7 @@ static int adis16400_set_filter(struct iio_dev *indio_dev, int sps, int val)
}
ret = adis_read_reg_16(&st->adis, ADIS16400_SENS_AVG, &val16);
- if (ret < 0)
+ if (ret)
return ret;
ret = adis_write_reg_16(&st->adis, ADIS16400_SENS_AVG,
@@ -615,7 +615,7 @@ static int adis16400_read_raw(struct iio_dev *indio_dev,
ret = adis_read_reg_16(&st->adis,
ADIS16400_SENS_AVG,
&val16);
- if (ret < 0) {
+ if (ret) {
mutex_unlock(&indio_dev->mlock);
return ret;
}
@@ -626,12 +626,12 @@ static int adis16400_read_raw(struct iio_dev *indio_dev,
*val2 = (ret % 1000) * 1000;
}
mutex_unlock(&indio_dev->mlock);
- if (ret < 0)
+ if (ret)
return ret;
return IIO_VAL_INT_PLUS_MICRO;
case IIO_CHAN_INFO_SAMP_FREQ:
ret = st->variant->get_freq(st);
- if (ret < 0)
+ if (ret)
return ret;
*val = ret / 1000;
*val2 = (ret % 1000) * 1000;
--
2.20.1
next prev parent reply other threads:[~2019-11-01 9:35 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-01 9:34 [PATCH 00/10] iio: adis: cleanups and fixes Alexandru Ardelean
2019-11-01 9:34 ` [PATCH 01/10] iio: gyro: adis16136: check ret val for non-zero vs less-than-zero Alexandru Ardelean
2019-11-03 10:15 ` Jonathan Cameron
2019-11-01 9:34 ` Alexandru Ardelean [this message]
2019-11-03 10:21 ` [PATCH 02/10] iio: imu: adis16400: " Jonathan Cameron
2019-11-04 7:40 ` Ardelean, Alexandru
2019-11-01 9:34 ` [PATCH 03/10] iio: imu: adis16460: " Alexandru Ardelean
2019-11-03 10:25 ` Jonathan Cameron
2019-11-01 9:34 ` [PATCH 04/10] iio: imu: adis16480: " Alexandru Ardelean
2019-11-03 10:27 ` Jonathan Cameron
2019-11-01 9:35 ` [PATCH 05/10] iio: imu: adis: " Alexandru Ardelean
2019-11-03 10:31 ` Jonathan Cameron
2019-11-01 9:35 ` [PATCH 06/10] iio: imu: adis16480: fix indentation of return statement Alexandru Ardelean
2019-11-03 10:35 ` Jonathan Cameron
2019-11-01 9:35 ` [PATCH 07/10] iio: imu: adis16480: prefer `unsigned int` over `unsigned` Alexandru Ardelean
2019-11-03 10:36 ` Jonathan Cameron
2019-11-01 9:35 ` [PATCH 08/10] iio: imu: adis16480: assign bias value only if operation succeeded Alexandru Ardelean
2019-11-03 10:41 ` Jonathan Cameron
2019-11-04 8:50 ` Ardelean, Alexandru
2019-11-01 9:35 ` [PATCH 09/10] iio: imu: adis: assign read val in debugfs hook only if op successful Alexandru Ardelean
2019-11-03 10:46 ` Jonathan Cameron
2019-11-01 9:35 ` [PATCH 10/10] iio: imu: adis: assign value only if return code zero in read funcs Alexandru Ardelean
2019-11-03 10:49 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191101093505.9408-3-alexandru.ardelean@analog.com \
--to=alexandru.ardelean@analog.com \
--cc=Michael.Hennerich@analog.com \
--cc=dragos.bogdan@analog.com \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).