linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexandru Ardelean <alexandru.ardelean@analog.com>
To: <linux-iio@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Cc: <lars@metafoo.de>, <Michael.Hennerich@analog.com>,
	<jic23@kernel.org>, <dragos.bogdan@analog.com>,
	Alexandru Ardelean <alexandru.ardelean@analog.com>
Subject: [PATCH 08/10] iio: imu: adis16480: assign bias value only if operation succeeded
Date: Fri, 1 Nov 2019 11:35:03 +0200	[thread overview]
Message-ID: <20191101093505.9408-9-alexandru.ardelean@analog.com> (raw)
In-Reply-To: <20191101093505.9408-1-alexandru.ardelean@analog.com>

This was found only after the whole thing with the inline functions, but
the compiler actually found something. The value of the `bias` (in
adis16480_get_calibbias()) should only be set if the read operation was
successful.

Fixes: 2f3abe6cbb6c9 ("iio:imu: Add support for the ADIS16480 and similar IMUs")
Signed-off-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
---
 drivers/iio/imu/adis16480.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/iio/imu/adis16480.c b/drivers/iio/imu/adis16480.c
index b9e2695bcfad..c0e7e768be41 100644
--- a/drivers/iio/imu/adis16480.c
+++ b/drivers/iio/imu/adis16480.c
@@ -451,12 +451,14 @@ static int adis16480_get_calibbias(struct iio_dev *indio_dev,
 	case IIO_MAGN:
 	case IIO_PRESSURE:
 		ret = adis_read_reg_16(&st->adis, reg, &val16);
-		*bias = sign_extend32(val16, 15);
+		if (ret == 0)
+			*bias = sign_extend32(val16, 15);
 		break;
 	case IIO_ANGL_VEL:
 	case IIO_ACCEL:
 		ret = adis_read_reg_32(&st->adis, reg, &val32);
-		*bias = sign_extend32(val32, 31);
+		if (ret == 0)
+			*bias = sign_extend32(val32, 31);
 		break;
 	default:
 		ret = -EINVAL;
-- 
2.20.1


  parent reply	other threads:[~2019-11-01  9:35 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-01  9:34 [PATCH 00/10] iio: adis: cleanups and fixes Alexandru Ardelean
2019-11-01  9:34 ` [PATCH 01/10] iio: gyro: adis16136: check ret val for non-zero vs less-than-zero Alexandru Ardelean
2019-11-03 10:15   ` Jonathan Cameron
2019-11-01  9:34 ` [PATCH 02/10] iio: imu: adis16400: " Alexandru Ardelean
2019-11-03 10:21   ` Jonathan Cameron
2019-11-04  7:40     ` Ardelean, Alexandru
2019-11-01  9:34 ` [PATCH 03/10] iio: imu: adis16460: " Alexandru Ardelean
2019-11-03 10:25   ` Jonathan Cameron
2019-11-01  9:34 ` [PATCH 04/10] iio: imu: adis16480: " Alexandru Ardelean
2019-11-03 10:27   ` Jonathan Cameron
2019-11-01  9:35 ` [PATCH 05/10] iio: imu: adis: " Alexandru Ardelean
2019-11-03 10:31   ` Jonathan Cameron
2019-11-01  9:35 ` [PATCH 06/10] iio: imu: adis16480: fix indentation of return statement Alexandru Ardelean
2019-11-03 10:35   ` Jonathan Cameron
2019-11-01  9:35 ` [PATCH 07/10] iio: imu: adis16480: prefer `unsigned int` over `unsigned` Alexandru Ardelean
2019-11-03 10:36   ` Jonathan Cameron
2019-11-01  9:35 ` Alexandru Ardelean [this message]
2019-11-03 10:41   ` [PATCH 08/10] iio: imu: adis16480: assign bias value only if operation succeeded Jonathan Cameron
2019-11-04  8:50     ` Ardelean, Alexandru
2019-11-01  9:35 ` [PATCH 09/10] iio: imu: adis: assign read val in debugfs hook only if op successful Alexandru Ardelean
2019-11-03 10:46   ` Jonathan Cameron
2019-11-01  9:35 ` [PATCH 10/10] iio: imu: adis: assign value only if return code zero in read funcs Alexandru Ardelean
2019-11-03 10:49   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191101093505.9408-9-alexandru.ardelean@analog.com \
    --to=alexandru.ardelean@analog.com \
    --cc=Michael.Hennerich@analog.com \
    --cc=dragos.bogdan@analog.com \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).