From: Dmitry Osipenko <digetx@gmail.com>
To: "Thierry Reding" <thierry.reding@gmail.com>,
"MyungJoo Ham" <myungjoo.ham@samsung.com>,
"Kyungmin Park" <kyungmin.park@samsung.com>,
"Chanwoo Choi" <cw00.choi@samsung.com>,
"Jonathan Hunter" <jonathanh@nvidia.com>,
"Tomeu Vizoso" <tomeu.vizoso@collabora.com>,
"Peter Geis" <pgwipeout@gmail.com>,
"Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: linux-pm@vger.kernel.org, linux-tegra@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v9 05/19] PM / devfreq: tegra30: Fix integer overflow on CPU's freq max out
Date: Tue, 5 Nov 2019 00:56:03 +0300 [thread overview]
Message-ID: <20191104215617.25544-6-digetx@gmail.com> (raw)
In-Reply-To: <20191104215617.25544-1-digetx@gmail.com>
There is another kHz-conversion bug in the code, resulting in integer
overflow. Although, this time the resulting value is 4294966296 and it's
close to ULONG_MAX, which is okay in this case.
Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com>
Tested-by: Peter Geis <pgwipeout@gmail.com>
Signed-off-by: Dmitry Osipenko <digetx@gmail.com>
---
drivers/devfreq/tegra30-devfreq.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/devfreq/tegra30-devfreq.c b/drivers/devfreq/tegra30-devfreq.c
index b50bd1615010..7d7b7eecc19c 100644
--- a/drivers/devfreq/tegra30-devfreq.c
+++ b/drivers/devfreq/tegra30-devfreq.c
@@ -69,6 +69,8 @@
#define KHZ 1000
+#define KHZ_MAX (ULONG_MAX / KHZ)
+
/* Assume that the bus is saturated if the utilization is 25% */
#define BUS_SATURATION_RATIO 25
@@ -170,7 +172,7 @@ struct tegra_actmon_emc_ratio {
};
static struct tegra_actmon_emc_ratio actmon_emc_ratios[] = {
- { 1400000, ULONG_MAX },
+ { 1400000, KHZ_MAX },
{ 1200000, 750000 },
{ 1100000, 600000 },
{ 1000000, 500000 },
--
2.23.0
next prev parent reply other threads:[~2019-11-04 22:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-04 21:55 [PATCH v9 00/19] More improvements for Tegra30 devfreq driver Dmitry Osipenko
2019-11-04 21:55 ` [PATCH v9 01/19] PM / devfreq: tegra30: Change irq type to unsigned int Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 02/19] PM / devfreq: tegra30: Keep interrupt disabled while governor is stopped Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 03/19] PM / devfreq: tegra30: Handle possible round-rate error Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 04/19] PM / devfreq: tegra30: Drop write-barrier Dmitry Osipenko
2019-11-04 21:56 ` Dmitry Osipenko [this message]
2019-11-04 21:56 ` [PATCH v9 06/19] PM / devfreq: tegra30: Use kHz units uniformly in the code Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 07/19] PM / devfreq: tegra30: Use CPUFreq notifier Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 08/19] PM / devfreq: tegra30: Move clk-notifier's registration to governor's start Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 09/19] PM / devfreq: tegra30: Reset boosting on startup Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 10/19] PM / devfreq: tegra30: Don't enable consecutive-down interrupt " Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 11/19] PM / devfreq: tegra30: Constify structs Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 12/19] PM / devfreq: tegra30: Include appropriate header Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 13/19] PM / devfreq: tegra30: Don't enable already enabled consecutive interrupts Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 14/19] PM / devfreq: tegra30: Disable consecutive interrupts when appropriate Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 15/19] PM / devfreq: tegra30: Use kHz units for dependency threshold Dmitry Osipenko
2019-11-05 4:02 ` Chanwoo Choi
2019-11-04 21:56 ` [PATCH v9 16/19] PM / devfreq: Add new interrupt_driven flag for governors Dmitry Osipenko
2019-11-05 4:01 ` Chanwoo Choi
2019-11-04 21:56 ` [PATCH v9 17/19] PM / devfreq: tegra30: Support variable polling interval Dmitry Osipenko
2019-11-05 4:02 ` Chanwoo Choi
2019-11-04 21:56 ` [PATCH v9 18/19] PM / devfreq: tegra30: Tune up MCCPU boost-down coefficient Dmitry Osipenko
2019-11-04 21:56 ` [PATCH v9 19/19] PM / devfreq: tegra20/30: Add Dmitry as a maintainer Dmitry Osipenko
2019-11-05 4:07 ` Chanwoo Choi
2019-11-05 13:29 ` Dmitry Osipenko
2019-11-06 1:24 ` Chanwoo Choi
2019-11-06 16:14 ` Dmitry Osipenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104215617.25544-6-digetx@gmail.com \
--to=digetx@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=jonathanh@nvidia.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=mirq-linux@rere.qmqm.pl \
--cc=myungjoo.ham@samsung.com \
--cc=pgwipeout@gmail.com \
--cc=thierry.reding@gmail.com \
--cc=tomeu.vizoso@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).