[v5,06/13] drivers: irqchip: qcom-pdc: Move to an SoC independent compatible
diff mbox series

Message ID 20191108092824.9773-7-rnayak@codeaurora.org
State New, archived
Headers show
Series
  • Add device tree support for sc7180
Related show

Commit Message

Rajendra Nayak Nov. 8, 2019, 9:28 a.m. UTC
Remove the sdm845 SoC specific compatible to make the driver
easily reusable across other SoC's with the same IP block.
This will reduce further churn adding any SoC specific
compatibles unless really needed.

Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
Reviewed-by: Lina Iyer <ilina@codeaurora.org>
Reviewed-by: Stephen Boyd <swboyd@chromium.org>
Cc: Marc Zyngier <maz@kernel.org>
---
 drivers/irqchip/qcom-pdc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Marc Zyngier Nov. 8, 2019, 9:40 a.m. UTC | #1
On 2019-11-08 10:37, Rajendra Nayak wrote:
> Remove the sdm845 SoC specific compatible to make the driver
> easily reusable across other SoC's with the same IP block.
> This will reduce further churn adding any SoC specific
> compatibles unless really needed.
>
> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> Reviewed-by: Lina Iyer <ilina@codeaurora.org>
> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> Cc: Marc Zyngier <maz@kernel.org>
> ---
>  drivers/irqchip/qcom-pdc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
> index faa7d61b9d6c..c175333bb646 100644
> --- a/drivers/irqchip/qcom-pdc.c
> +++ b/drivers/irqchip/qcom-pdc.c
> @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node
> *node, struct device_node *parent)
>  	return ret;
>  }
>
> -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
> +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);

Acked-by: Marc Zyngier <marc.zyngier@arm.com>

How do you want me get this (and the DT change) merged? I can either 
take
these two patches in the irqchip tree, or you arrange them to be taken
by the platform maintainers. Your call.

Thanks,

         M.
Marc Zyngier Nov. 8, 2019, 9:43 a.m. UTC | #2
On 2019-11-08 10:50, Marc Zyngier wrote:
> On 2019-11-08 10:37, Rajendra Nayak wrote:
>> Remove the sdm845 SoC specific compatible to make the driver
>> easily reusable across other SoC's with the same IP block.
>> This will reduce further churn adding any SoC specific
>> compatibles unless really needed.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> Reviewed-by: Lina Iyer <ilina@codeaurora.org>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> Cc: Marc Zyngier <maz@kernel.org>
>> ---
>>  drivers/irqchip/qcom-pdc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
>> index faa7d61b9d6c..c175333bb646 100644
>> --- a/drivers/irqchip/qcom-pdc.c
>> +++ b/drivers/irqchip/qcom-pdc.c
>> @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node
>> *node, struct device_node *parent)
>>  	return ret;
>>  }
>>
>> -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
>> +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);
>
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>

I need to have my hands fixed. The real tag is:

Acked-by: Marc Zyngier <maz@kernel.org>

One day, I'll manage that...

         M.
Rajendra Nayak Nov. 8, 2019, 9:55 a.m. UTC | #3
On 11/8/2019 3:10 PM, Marc Zyngier wrote:
> On 2019-11-08 10:37, Rajendra Nayak wrote:
>> Remove the sdm845 SoC specific compatible to make the driver
>> easily reusable across other SoC's with the same IP block.
>> This will reduce further churn adding any SoC specific
>> compatibles unless really needed.
>>
>> Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> Reviewed-by: Lina Iyer <ilina@codeaurora.org>
>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> Cc: Marc Zyngier <maz@kernel.org>
>> ---
>>  drivers/irqchip/qcom-pdc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
>> index faa7d61b9d6c..c175333bb646 100644
>> --- a/drivers/irqchip/qcom-pdc.c
>> +++ b/drivers/irqchip/qcom-pdc.c
>> @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node
>> *node, struct device_node *parent)
>>      return ret;
>>  }
>>
>> -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
>> +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);
> 
> Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> 
> How do you want me get this (and the DT change) merged? I can either take
> these two patches in the irqchip tree, or you arrange them to be taken
> by the platform maintainers. Your call.

I think it makes sense for you to take these two via your tree (The driver
and binding doc updates) and the DT node addition for pdc to go via Andy/Bjorn.
Andy/Bjorn, does that sound fine?
Bjorn Andersson Nov. 11, 2019, 7:10 a.m. UTC | #4
On Fri 08 Nov 01:55 PST 2019, Rajendra Nayak wrote:

> 
> On 11/8/2019 3:10 PM, Marc Zyngier wrote:
> > On 2019-11-08 10:37, Rajendra Nayak wrote:
> > > Remove the sdm845 SoC specific compatible to make the driver
> > > easily reusable across other SoC's with the same IP block.
> > > This will reduce further churn adding any SoC specific
> > > compatibles unless really needed.
> > > 
> > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
> > > Reviewed-by: Lina Iyer <ilina@codeaurora.org>
> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
> > > Cc: Marc Zyngier <maz@kernel.org>
> > > ---
> > >  drivers/irqchip/qcom-pdc.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
> > > index faa7d61b9d6c..c175333bb646 100644
> > > --- a/drivers/irqchip/qcom-pdc.c
> > > +++ b/drivers/irqchip/qcom-pdc.c
> > > @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node
> > > *node, struct device_node *parent)
> > >      return ret;
> > >  }
> > > 
> > > -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
> > > +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);
> > 
> > Acked-by: Marc Zyngier <marc.zyngier@arm.com>
> > 
> > How do you want me get this (and the DT change) merged? I can either take
> > these two patches in the irqchip tree, or you arrange them to be taken
> > by the platform maintainers. Your call.
> 
> I think it makes sense for you to take these two via your tree (The driver
> and binding doc updates) and the DT node addition for pdc to go via Andy/Bjorn.
> Andy/Bjorn, does that sound fine?
> 

Yes, that sounds good.

Regards,
Bjorn
Marc Zyngier Nov. 11, 2019, 10:47 a.m. UTC | #5
On 2019-11-11 08:19, Bjorn Andersson wrote:
> On Fri 08 Nov 01:55 PST 2019, Rajendra Nayak wrote:
>
>>
>> On 11/8/2019 3:10 PM, Marc Zyngier wrote:
>> > On 2019-11-08 10:37, Rajendra Nayak wrote:
>> > > Remove the sdm845 SoC specific compatible to make the driver
>> > > easily reusable across other SoC's with the same IP block.
>> > > This will reduce further churn adding any SoC specific
>> > > compatibles unless really needed.
>> > >
>> > > Signed-off-by: Rajendra Nayak <rnayak@codeaurora.org>
>> > > Reviewed-by: Lina Iyer <ilina@codeaurora.org>
>> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>> > > Cc: Marc Zyngier <maz@kernel.org>
>> > > ---
>> > >  drivers/irqchip/qcom-pdc.c | 2 +-
>> > >  1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > diff --git a/drivers/irqchip/qcom-pdc.c 
>> b/drivers/irqchip/qcom-pdc.c
>> > > index faa7d61b9d6c..c175333bb646 100644
>> > > --- a/drivers/irqchip/qcom-pdc.c
>> > > +++ b/drivers/irqchip/qcom-pdc.c
>> > > @@ -309,4 +309,4 @@ static int qcom_pdc_init(struct device_node
>> > > *node, struct device_node *parent)
>> > >      return ret;
>> > >  }
>> > >
>> > > -IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
>> > > +IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);
>> >
>> > Acked-by: Marc Zyngier <marc.zyngier@arm.com>
>> >
>> > How do you want me get this (and the DT change) merged? I can 
>> either take
>> > these two patches in the irqchip tree, or you arrange them to be 
>> taken
>> > by the platform maintainers. Your call.
>>
>> I think it makes sense for you to take these two via your tree (The 
>> driver
>> and binding doc updates) and the DT node addition for pdc to go via 
>> Andy/Bjorn.
>> Andy/Bjorn, does that sound fine?
>>
>
> Yes, that sounds good.

Applied to irqchip/next

         M.

Patch
diff mbox series

diff --git a/drivers/irqchip/qcom-pdc.c b/drivers/irqchip/qcom-pdc.c
index faa7d61b9d6c..c175333bb646 100644
--- a/drivers/irqchip/qcom-pdc.c
+++ b/drivers/irqchip/qcom-pdc.c
@@ -309,4 +309,4 @@  static int qcom_pdc_init(struct device_node *node, struct device_node *parent)
 	return ret;
 }
 
-IRQCHIP_DECLARE(pdc_sdm845, "qcom,sdm845-pdc", qcom_pdc_init);
+IRQCHIP_DECLARE(qcom_pdc, "qcom,pdc", qcom_pdc_init);