checkpatch: remove "ipc" from list of expected toplevel directories
diff mbox series

Message ID 20191108160428.9632-1-ggherdovich@suse.cz
State New, archived
Headers show
Series
  • checkpatch: remove "ipc" from list of expected toplevel directories
Related show

Commit Message

Giovanni Gherdovich Nov. 8, 2019, 4:04 p.m. UTC
checkpatch.pl uses a list of expected directory names to understand if it's
being run from the top of a kernel tree. Commit 76128326f97c ("toplevel:
Move ipc/ to kernel/ipc/: move the files") removed a toplevel directory, so
checkpatch.pl need to update its list.

Signed-off-by: Giovanni Gherdovich <ggherdovich@suse.cz>
---
 scripts/checkpatch.pl | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Giovanni Gherdovich Nov. 8, 2019, 4:27 p.m. UTC | #1
On Fri, 2019-11-08 at 17:04 +0100, Giovanni Gherdovich wrote:
> checkpatch.pl uses a list of expected directory names to understand if it's
> being run from the top of a kernel tree. Commit 76128326f97c ("toplevel:
> Move ipc/ to kernel/ipc/: move the files") removed a toplevel directory, so
> checkpatch.pl need to update its list.
> 
> Signed-off-by: Giovanni Gherdovich <ggherdovich@suse.cz>
> ---
>  scripts/checkpatch.pl | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
> index 6fcc66afb088..93b8fd1eea57 100755
> --- a/scripts/checkpatch.pl
> +++ b/scripts/checkpatch.pl
> @@ -1099,7 +1099,7 @@ sub top_of_kernel_tree {
>  	my @tree_check = (
>  		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
>  		"README", "Documentation", "arch", "include", "drivers",
> -		"fs", "init", "ipc", "kernel", "lib", "scripts",
> +		"fs", "init", "kernel", "lib", "scripts",
>  	);
>  
>  	foreach my $check (@tree_check) {

Nope, this was already fixed by Yunfeng Ye with
https://lore.kernel.org/lkml/bd70558e-5126-6460-81d7-edf72cbbce7a@huawei.com/
plus the ipc/ directory is now back in its place.

Sorry for the noise,
Giovanni

Patch
diff mbox series

diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl
index 6fcc66afb088..93b8fd1eea57 100755
--- a/scripts/checkpatch.pl
+++ b/scripts/checkpatch.pl
@@ -1099,7 +1099,7 @@  sub top_of_kernel_tree {
 	my @tree_check = (
 		"COPYING", "CREDITS", "Kbuild", "MAINTAINERS", "Makefile",
 		"README", "Documentation", "arch", "include", "drivers",
-		"fs", "init", "ipc", "kernel", "lib", "scripts",
+		"fs", "init", "kernel", "lib", "scripts",
 	);
 
 	foreach my $check (@tree_check) {