linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benoit Parrot <bparrot@ti.com>
To: Tony Lindgren <tony@atomide.com>, Tero Kristo <t-kristo@ti.com>
Cc: <linux-omap@vger.kernel.org>, <linux-clk@vger.kernel.org>,
	<linux-arm-kernel@lists.infradead.org>,
	<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	Benoit Parrot <bparrot@ti.com>
Subject: [Patch v3 03/10] ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only
Date: Tue, 12 Nov 2019 08:27:46 -0600	[thread overview]
Message-ID: <20191112142753.22976-4-bparrot@ti.com> (raw)
In-Reply-To: <20191112142753.22976-1-bparrot@ti.com>

Both CAL and VIP rely on this clock domain. But CAL DPHY require
LVDSRX_96M_GFCLK to be active. When this domain is set to HWSUP the
LVDSRX_96M_GFCLK is on;y active when VIP1 clock is also active.  If only
CAL on DRA72x (which uses the VIP2 clkctrl) probes the CAM domain is
enabled but the LVDSRX_96M_GFCLK is left gated. Since LVDSRX_96M_GFCLK
is sourcing the input clock to the DPHY then actual frame capture cannot
start as the phy are inactive.

So we either have to also enabled VIP1 even if we don't intend on using
it or we need to set the CAM domain to use SWSUP only.

This patch implements the latter.

Signed-off-by: Benoit Parrot <bparrot@ti.com>
---
 arch/arm/mach-omap2/clockdomains7xx_data.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/mach-omap2/clockdomains7xx_data.c b/arch/arm/mach-omap2/clockdomains7xx_data.c
index 3068802824b7..27835c4d1aa9 100644
--- a/arch/arm/mach-omap2/clockdomains7xx_data.c
+++ b/arch/arm/mach-omap2/clockdomains7xx_data.c
@@ -606,7 +606,7 @@ static struct clockdomain cam_7xx_clkdm = {
 	.dep_bit	  = DRA7XX_CAM_STATDEP_SHIFT,
 	.wkdep_srcs	  = cam_wkup_sleep_deps,
 	.sleepdep_srcs	  = cam_wkup_sleep_deps,
-	.flags		  = CLKDM_CAN_HWSUP_SWSUP,
+	.flags		  = CLKDM_CAN_SWSUP,
 };
 
 static struct clockdomain l4per_7xx_clkdm = {
-- 
2.17.1


  parent reply	other threads:[~2019-11-12 14:25 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-12 14:27 [Patch v3 00/10] ARM: dts: dra7: add cal nodes Benoit Parrot
2019-11-12 14:27 ` [Patch v3 01/10] clk: ti: dra7: add cam clkctrl data Benoit Parrot
2019-11-12 15:27   ` Tony Lindgren
2019-11-18 17:38   ` Rob Herring
2019-11-12 14:27 ` [Patch v3 02/10] ARM: dts: dra7: add cam clkctrl node Benoit Parrot
2019-11-12 15:29   ` Tony Lindgren
2019-11-12 14:27 ` Benoit Parrot [this message]
2019-11-12 15:31   ` [Patch v3 03/10] ARM: OMAP: DRA7xx: Make CAM clock domain SWSUP only Tony Lindgren
2019-11-12 14:27 ` [Patch v3 04/10] ARM: dts: dra7-l4: Add ti-sysc node for CAM Benoit Parrot
2019-11-12 14:27 ` [Patch v3 05/10] ARM: dts: DRA72: Add CAL dtsi node Benoit Parrot
2019-11-12 15:34   ` Tony Lindgren
2019-11-12 14:27 ` [Patch v3 06/10] arm: dts: dra72-evm-common: Add entries for the CSI2 cameras Benoit Parrot
2019-11-12 14:27 ` [Patch v3 07/10] arm: dtsi: dra76x: Add CAL dtsi node Benoit Parrot
2019-11-12 14:27 ` [Patch v3 08/10] arm: dts: dra76-evm: Add CAL and OV5640 nodes Benoit Parrot
2019-11-12 14:27 ` [Patch v3 09/10] arm64: dts: k3-am65-main Add CAL node Benoit Parrot
2019-11-12 15:38   ` Tony Lindgren
2019-11-12 14:27 ` [Patch v3 10/10] arm64: dts: k3-am654-base-board: Add CSI2 OV5640 camera Benoit Parrot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191112142753.22976-4-bparrot@ti.com \
    --to=bparrot@ti.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=t-kristo@ti.com \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).