From: Ikjoon Jang <ikjn@chromium.org>
To: linux-usb@vger.kernel.org, devicetree@vger.kernel.org
Cc: linux-kernel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Alan Stern <stern@rowland.harvard.edu>,
Suwan Kim <suwan.kim027@gmail.com>,
"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Johan Hovold <johan@kernel.org>,
Nicolas Boitchat <drinkcat@chromium.org>,
Ikjoon Jang <ikjn@chromium.org>
Subject: [PATCH 2/2] usb: overridable hub bInterval by device node
Date: Sun, 17 Nov 2019 11:33:05 +0800 [thread overview]
Message-ID: <20191117033305.259789-1-ikjn@chromium.org> (raw)
This patch enables hub device to override its own endpoint descriptor's
bInterval when the hub has a device node with "hub,interval" property,
Some existing hub devices have adjustable interval so the device is
allowed to use different bInterval. This is useful when the hub's default
bInterval is too big, so child device's waking up from autosuspend
takes much time.
Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
---
drivers/usb/core/config.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 5f40117e68e7..234ca6124c98 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -6,6 +6,7 @@
#include <linux/usb.h>
#include <linux/usb/ch9.h>
#include <linux/usb/hcd.h>
+#include <linux/usb/of.h>
#include <linux/usb/quirks.h>
#include <linux/module.h>
#include <linux/slab.h>
@@ -257,6 +258,11 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno, int inum,
memcpy(&endpoint->desc, d, n);
INIT_LIST_HEAD(&endpoint->urb_list);
+ /* device node property overrides bInterval */
+ if (unlikely(usb_of_has_combined_node(to_usb_device(ddev))))
+ of_property_read_u8(ddev->of_node, "hub, interval",
+ &d->bInterval);
+
/*
* Fix up bInterval values outside the legal range.
* Use 10 or 8 ms if no proper value can be guessed.
--
2.24.0.432.g9d3f5f5b63-goog
next reply other threads:[~2019-11-17 3:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 3:33 Ikjoon Jang [this message]
2019-11-17 7:13 ` [PATCH 2/2] usb: overridable hub bInterval by device node Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191117033305.259789-1-ikjn@chromium.org \
--to=ikjn@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=suwan.kim027@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).