From: Aditya Pakki <pakki001@umn.edu>
To: pakki001@umn.edu
Cc: kjlu@umn.edu, "Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"David (ChunMing) Zhou" <David1.Zhou@amd.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"Anthony Koo" <Anthony.Koo@amd.com>, "Jun Lei" <Jun.Lei@amd.com>,
"David Francis" <David.Francis@amd.com>,
"Eric Yang" <Eric.Yang2@amd.com>,
"Nikola Cornij" <nikola.cornij@amd.com>,
"Eric Bernstein" <eric.bernstein@amd.com>,
"Chris Park" <Chris.Park@amd.com>,
"Wenjing Liu" <Wenjing.Liu@amd.com>,
"David Galiffi" <david.galiffi@amd.com>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH] drm/amd/display: Fix error returned by program_hpd_filter
Date: Sun, 17 Nov 2019 11:22:34 -0600 [thread overview]
Message-ID: <20191117172236.2140-1-pakki001@umn.edu> (raw)
program_hpd_filter() currently fails to check for the errors
returned in construct(). This patch returns error in
case of failure.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
index ca20b150afcc..bbb648a50c41 100644
--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -1379,9 +1379,8 @@ static bool construct(
* If GPIO isn't programmed correctly HPD might not rise or drain
* fast enough, leading to bounces.
*/
- program_hpd_filter(link);
+ return program_hpd_filter(link);
- return true;
device_tag_fail:
link->link_enc->funcs->destroy(&link->link_enc);
link_enc_create_fail:
--
2.17.1
next reply other threads:[~2019-11-17 17:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 17:22 Aditya Pakki [this message]
2019-12-31 15:08 ` [PATCH] drm/amd/display: Fix error returned by program_hpd_filter Harry Wentland
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191117172236.2140-1-pakki001@umn.edu \
--to=pakki001@umn.edu \
--cc=Anthony.Koo@amd.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Chris.Park@amd.com \
--cc=David.Francis@amd.com \
--cc=David1.Zhou@amd.com \
--cc=Eric.Yang2@amd.com \
--cc=Jun.Lei@amd.com \
--cc=Wenjing.Liu@amd.com \
--cc=airlied@linux.ie \
--cc=alexander.deucher@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=david.galiffi@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=eric.bernstein@amd.com \
--cc=harry.wentland@amd.com \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=nikola.cornij@amd.com \
--cc=sunpeng.li@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).