From: Aditya Pakki <pakki001@umn.edu>
To: pakki001@umn.edu
Cc: kjlu@umn.edu, David Woodhouse <dwmw2@infradead.org>,
Richard Weinberger <richard@nod.at>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] jffs2: Reduce the severity level of logging errors
Date: Sun, 17 Nov 2019 11:44:12 -0600 [thread overview]
Message-ID: <20191117174413.2876-1-pakki001@umn.edu> (raw)
Unlike other instances of critical errors that call BUG(), kmalloc
failure in jffs2_wbuf_recover does not require pr_crit. Replace this
error logging with pr_warn().
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
fs/jffs2/wbuf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/jffs2/wbuf.c b/fs/jffs2/wbuf.c
index c6821a509481..59e145220b51 100644
--- a/fs/jffs2/wbuf.c
+++ b/fs/jffs2/wbuf.c
@@ -339,7 +339,7 @@ static void jffs2_wbuf_recover(struct jffs2_sb_info *c)
buf = kmalloc(end - start, GFP_KERNEL);
if (!buf) {
- pr_crit("Malloc failure in wbuf recovery. Data loss ensues.\n");
+ pr_warn("Malloc failure in wbuf recovery. Data loss ensues.\n");
goto read_failed;
}
@@ -354,7 +354,7 @@ static void jffs2_wbuf_recover(struct jffs2_sb_info *c)
ret = 0;
if (ret || retlen != c->wbuf_ofs - start) {
- pr_crit("Old data are already lost in wbuf recovery. Data loss ensues.\n");
+ pr_warn("Old data are already lost in wbuf recovery. Data loss ensues.\n");
kfree(buf);
buf = NULL;
--
2.17.1
next reply other threads:[~2019-11-17 17:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 17:44 Aditya Pakki [this message]
2019-11-18 8:37 ` [PATCH] jffs2: Reduce the severity level of logging errors Richard Weinberger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191117174413.2876-1-pakki001@umn.edu \
--to=pakki001@umn.edu \
--cc=dwmw2@infradead.org \
--cc=kjlu@umn.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).