From: patrick.rudolph@9elements.com
To: linux-kernel@vger.kernel.org
Cc: coreboot@coreboot.org, Arthur Heymans <arthur@aheymans.xyz>,
Patrick Rudolph <patrick.rudolph@9elements.com>,
Thomas Gleixner <tglx@linutronix.de>,
Alexios Zavras <alexios.zavras@intel.com>,
Allison Randal <allison@lohutok.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: [Patch v2 2/3] firmware: google: Unregister driver_info on failure and exit in gsmi
Date: Mon, 18 Nov 2019 09:38:59 +0100 [thread overview]
Message-ID: <20191118083903.19311-2-patrick.rudolph@9elements.com> (raw)
In-Reply-To: <20191118083903.19311-1-patrick.rudolph@9elements.com>
From: Arthur Heymans <arthur@aheymans.xyz>
Fix a bug where the kernel module couldn't be loaded after unloading,
as the platform driver wasn't released on exit.
Signed-off-by: Arthur Heymans <arthur@aheymans.xyz>
Signed-off-by: Patrick Rudolph <patrick.rudolph@9elements.com>
---
drivers/firmware/google/gsmi.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/firmware/google/gsmi.c b/drivers/firmware/google/gsmi.c
index edaa4e5d84ad..974c769b75cf 100644
--- a/drivers/firmware/google/gsmi.c
+++ b/drivers/firmware/google/gsmi.c
@@ -1016,6 +1016,9 @@ static __init int gsmi_init(void)
dma_pool_destroy(gsmi_dev.dma_pool);
platform_device_unregister(gsmi_dev.pdev);
pr_info("gsmi: failed to load: %d\n", ret);
+#ifdef CONFIG_PM
+ platform_driver_unregister(&gsmi_driver_info);
+#endif
return ret;
}
@@ -1037,6 +1040,9 @@ static void __exit gsmi_exit(void)
gsmi_buf_free(gsmi_dev.name_buf);
dma_pool_destroy(gsmi_dev.dma_pool);
platform_device_unregister(gsmi_dev.pdev);
+#ifdef CONFIG_PM
+ platform_driver_unregister(&gsmi_driver_info);
+#endif
}
module_init(gsmi_init);
--
2.21.0
next prev parent reply other threads:[~2019-11-18 8:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-18 8:38 [Patch v2 1/3] firmware: google: Release devices before unregistering the bus patrick.rudolph
2019-11-18 8:38 ` patrick.rudolph [this message]
2019-11-18 8:39 ` [Patch v2 3/3] firmware: google: Probe for a GSMI handler in firmware patrick.rudolph
2019-11-18 8:59 ` [Patch v2 1/3] firmware: google: Release devices before unregistering the bus Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118083903.19311-2-patrick.rudolph@9elements.com \
--to=patrick.rudolph@9elements.com \
--cc=alexios.zavras@intel.com \
--cc=allison@lohutok.net \
--cc=arthur@aheymans.xyz \
--cc=coreboot@coreboot.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).