From: Pankaj Sharma <pankj.sharma@samsung.com>
To: linux-can@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Cc: wg@grandegger.com, mkl@pengutronix.de, davem@davemloft.net,
dmurphy@ti.com, rcsekar@samsung.com, pankaj.dubey@samsung.com,
Pankaj Sharma <pankj.sharma@samsung.com>,
Sriram Dash <sriram.dash@samsung.com>
Subject: [PATCH 2/2] can: m_can_platform: remove unnecessary m_can_class_resume() call
Date: Tue, 19 Nov 2019 15:50:38 +0530 [thread overview]
Message-ID: <1574158838-4616-3-git-send-email-pankj.sharma@samsung.com> (raw)
In-Reply-To: <1574158838-4616-1-git-send-email-pankj.sharma@samsung.com>
The function m_can_runtime_resume() is getting recursively called from
m_can_class_resume(). This results in a lock up.
We need not call m_can_class_resume() during m_can_runtime_resume().
Fixes: f524f829b75a ("can: m_can: Create a m_can platform framework")
Signed-off-by: Pankaj Sharma <pankj.sharma@samsung.com>
Signed-off-by: Sriram Dash <sriram.dash@samsung.com>
---
drivers/net/can/m_can/m_can_platform.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/net/can/m_can/m_can_platform.c b/drivers/net/can/m_can/m_can_platform.c
index 2eaa354..38ea5e6 100644
--- a/drivers/net/can/m_can/m_can_platform.c
+++ b/drivers/net/can/m_can/m_can_platform.c
@@ -166,8 +166,6 @@ static int __maybe_unused m_can_runtime_resume(struct device *dev)
if (err)
clk_disable_unprepare(mcan_class->hclk);
- m_can_class_resume(dev);
-
return err;
}
--
2.7.4
next prev parent reply other threads:[~2019-11-19 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20191119102134epcas5p4d3c1b18203e2001c189b9fa7a0e3aab5@epcas5p4.samsung.com>
2019-11-19 10:20 ` [PATCH 0/2] can: m_can_platform: Bug fix of kernel panic for Pankaj Sharma
[not found] ` <CGME20191119102155epcas5p34ca3dfaba9eef8de24d1bc9d64ef5335@epcas5p3.samsung.com>
2019-11-19 10:20 ` [PATCH 1/2] can: m_can_platform: set net_device structure as driver data Pankaj Sharma
2019-11-19 14:43 ` Dan Murphy
[not found] ` <CGME20191119102201epcas5p4e215c25d5d07269a7afb1f86fac0be65@epcas5p4.samsung.com>
2019-11-19 10:20 ` Pankaj Sharma [this message]
2019-11-19 14:45 ` [PATCH 2/2] can: m_can_platform: remove unnecessary m_can_class_resume() call Dan Murphy
2019-12-05 20:57 ` [PATCH 0/2] can: m_can_platform: Bug fix of kernel panic for Dan Murphy
2019-12-06 6:53 ` pankj.sharma
2019-12-06 7:39 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574158838-4616-3-git-send-email-pankj.sharma@samsung.com \
--to=pankj.sharma@samsung.com \
--cc=davem@davemloft.net \
--cc=dmurphy@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pankaj.dubey@samsung.com \
--cc=rcsekar@samsung.com \
--cc=sriram.dash@samsung.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).