From: Corentin Labbe <clabbe@baylibre.com>
To: airlied@redhat.com, airlied@linux.ie, arnd@arndb.de,
fenghua.yu@intel.com, gregkh@linuxfoundation.org,
tony.luck@intel.com
Cc: linux-ia64@vger.kernel.org, linux-kernel@vger.kernel.org,
Corentin Labbe <clabbe@baylibre.com>
Subject: [PATCH v2 5/5] ia64: agp: Replace empty define with do while
Date: Thu, 21 Nov 2019 08:14:45 +0000 [thread overview]
Message-ID: <1574324085-4338-6-git-send-email-clabbe@baylibre.com> (raw)
In-Reply-To: <1574324085-4338-1-git-send-email-clabbe@baylibre.com>
It's dangerous to use empty code define.
Furthermore it lead to the following warning:
drivers/char/agp/generic.c: In function « agp_generic_destroy_page »:
drivers/char/agp/generic.c:1266:28: attention : suggest braces around empty body in an « if » statement [-Wempty-body]
So let's replace emptyness by "do {} while(0)"
Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
---
arch/ia64/include/asm/agp.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/ia64/include/asm/agp.h b/arch/ia64/include/asm/agp.h
index 2b451c4496da..0261507dc264 100644
--- a/arch/ia64/include/asm/agp.h
+++ b/arch/ia64/include/asm/agp.h
@@ -14,8 +14,8 @@
* in coherent mode, which lets us map the AGP memory as normal (write-back) memory
* (unlike x86, where it gets mapped "write-coalescing").
*/
-#define map_page_into_agp(page) /* nothing */
-#define unmap_page_from_agp(page) /* nothing */
+#define map_page_into_agp(page) do { } while (0)
+#define unmap_page_from_agp(page) do { } while (0)
#define flush_agp_cache() mb()
/* GATT allocation. Returns/accepts GATT kernel virtual address. */
--
2.23.0
next prev parent reply other threads:[~2019-11-21 8:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 8:14 [PATCH v2 0/5] agp: minor fixes Corentin Labbe
2019-11-21 8:14 ` [PATCH v2 1/5] agp: remove unused variable size in agp_generic_create_gatt_table Corentin Labbe
2019-11-21 8:14 ` [PATCH v2 2/5] agp: move AGPGART_MINOR to include/linux/miscdevice.h Corentin Labbe
2019-11-21 8:14 ` [PATCH v2 3/5] agp: remove unused variable num_segments Corentin Labbe
2019-11-21 8:14 ` [PATCH v2 4/5] agp: Add bridge parameter documentation Corentin Labbe
2019-11-21 8:14 ` Corentin Labbe [this message]
2019-11-21 9:05 ` [PATCH v2 0/5] agp: minor fixes Arnd Bergmann
2019-12-02 13:32 ` [PATCH v2 0/5] agp: minor fixes, does the maintainer still there ? LABBE Corentin
2019-12-02 20:01 ` David Airlie
2019-12-05 15:29 ` LABBE Corentin
2019-12-05 19:54 ` David Airlie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574324085-4338-6-git-send-email-clabbe@baylibre.com \
--to=clabbe@baylibre.com \
--cc=airlied@linux.ie \
--cc=airlied@redhat.com \
--cc=arnd@arndb.de \
--cc=fenghua.yu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-ia64@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).