crypto: talitos - Fix build error by selecting LIB_DES
diff mbox series

Message ID 20191126112836.tnim24tiafufe7z4@gondor.apana.org.au
State Accepted
Commit dbc2e87bd8b6d3cc79730b3a49c5163b4c386b49
Headers show
Series
  • crypto: talitos - Fix build error by selecting LIB_DES
Related show

Commit Message

Herbert Xu Nov. 26, 2019, 11:28 a.m. UTC
On Sun, Nov 24, 2019 at 07:42:21AM +0800, kbuild test robot wrote:
>
> All errors (new ones prefixed by >>):
> 
>    drivers/crypto/talitos.o: In function `crypto_des_verify_key':
> >> include/crypto/internal/des.h:31: undefined reference to `des_expand_key'

This patch should fix it.

---8<---
The talitos driver needs to select LIB_DES as it needs calls
des_expand_key.

Fixes: 9d574ae8ebc1 ("crypto: talitos/des - switch to new...")
Cc: <stable@vger.kernel.org>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

Comments

Ard Biesheuvel Nov. 26, 2019, 11:37 a.m. UTC | #1
On Tue, 26 Nov 2019 at 12:28, Herbert Xu <herbert@gondor.apana.org.au> wrote:
>
> On Sun, Nov 24, 2019 at 07:42:21AM +0800, kbuild test robot wrote:
> >
> > All errors (new ones prefixed by >>):
> >
> >    drivers/crypto/talitos.o: In function `crypto_des_verify_key':
> > >> include/crypto/internal/des.h:31: undefined reference to `des_expand_key'
>
> This patch should fix it.
>
> ---8<---
> The talitos driver needs to select LIB_DES as it needs calls
> des_expand_key.
>
> Fixes: 9d574ae8ebc1 ("crypto: talitos/des - switch to new...")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
>

Acked-by: Ard Biesheuvel <ardb@kernel.org>

> diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
> index 43ed1b621718..91eb768d4221 100644
> --- a/drivers/crypto/Kconfig
> +++ b/drivers/crypto/Kconfig
> @@ -289,6 +289,7 @@ config CRYPTO_DEV_TALITOS
>         select CRYPTO_AUTHENC
>         select CRYPTO_SKCIPHER
>         select CRYPTO_HASH
> +       select CRYPTO_LIB_DES
>         select HW_RANDOM
>         depends on FSL_SOC
>         help
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Patch
diff mbox series

diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 43ed1b621718..91eb768d4221 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -289,6 +289,7 @@  config CRYPTO_DEV_TALITOS
 	select CRYPTO_AUTHENC
 	select CRYPTO_SKCIPHER
 	select CRYPTO_HASH
+	select CRYPTO_LIB_DES
 	select HW_RANDOM
 	depends on FSL_SOC
 	help