From: Michal Suchanek <msuchanek@suse.de>
To: linuxppc-dev@lists.ozlabs.org
Cc: Michal Suchanek <msuchanek@suse.de>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
Michael Ellerman <mpe@ellerman.id.au>,
Oleg Nesterov <oleg@redhat.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Christian Brauner <christian@brauner.io>,
Nicholas Piggin <npiggin@gmail.com>,
Allison Randal <allison@lohutok.net>,
"Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>,
Thomas Gleixner <tglx@linutronix.de>,
Breno Leitao <leitao@debian.org>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Claudio Carvalho <cclaudio@linux.ibm.com>,
Russell Currey <ruscur@russell.cc>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Mahesh Salgaonkar <mahesh@linux.vnet.ibm.com>,
Arnd Bergmann <arnd@arndb.de>,
Geert Uytterhoeven <geert@linux-m68k.org>,
Firoz Khan <firoz.khan@linaro.org>,
Dmitry Vyukov <dvyukov@google.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Hari Bathini <hbathini@linux.ibm.com>,
Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
Nicolai Stange <nstange@suse.de>,
Valentin Schneider <valentin.schneider@arm.com>,
Diana Craciun <diana.craciun@nxp.com>,
Daniel Axtens <dja@axtens.net>,
Michael Neuling <mikey@neuling.org>,
Gustavo Romero <gromero@linux.ibm.com>,
Mathieu Malaterre <malat@debian.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Heiko Carstens <heiko.carstens@de.ibm.com>,
David Howells <dhowells@redhat.com>,
Brajeswar Ghosh <brajeswar.linux@gmail.com>,
Jagadeesh Pagadala <jagdsh.linux@gmail.com>,
David Hildenbrand <david@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
Madhavan Srinivasan <maddy@linux.vnet.ibm.com>,
linux-kernel@vger.kernel.org
Subject: [PATCH v2 rebase 26/34] powerpc/64: system call: Fix sparse warning about missing declaration
Date: Wed, 27 Nov 2019 11:39:02 +0100 [thread overview]
Message-ID: <f45bdb3ccb7c6a0c7ee5ff0612a80bce2f44dc0b.1574803685.git.msuchanek@suse.de> (raw)
In-Reply-To: <cover.1574803684.git.msuchanek@suse.de>
Sparse warns about missing declarations for these functions:
+arch/powerpc/kernel/syscall_64.c:108:23: warning: symbol 'syscall_exit_prepare' was not declared. Should it be static?
+arch/powerpc/kernel/syscall_64.c:18:6: warning: symbol 'system_call_exception' was not declared. Should it be static?
+arch/powerpc/kernel/syscall_64.c:200:23: warning: symbol 'interrupt_exit_user_prepare' was not declared. Should it be static?
+arch/powerpc/kernel/syscall_64.c:288:23: warning: symbol 'interrupt_exit_kernel_prepare' was not declared. Should it be static?
Add declaration for them.
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
arch/powerpc/include/asm/asm-prototypes.h | 6 ++++++
arch/powerpc/kernel/syscall_64.c | 1 +
2 files changed, 7 insertions(+)
diff --git a/arch/powerpc/include/asm/asm-prototypes.h b/arch/powerpc/include/asm/asm-prototypes.h
index 399ca63196e4..841746357833 100644
--- a/arch/powerpc/include/asm/asm-prototypes.h
+++ b/arch/powerpc/include/asm/asm-prototypes.h
@@ -96,6 +96,12 @@ ppc_select(int n, fd_set __user *inp, fd_set __user *outp, fd_set __user *exp, s
unsigned long __init early_init(unsigned long dt_ptr);
void __init machine_init(u64 dt_ptr);
#endif
+#ifdef CONFIG_PPC64
+long system_call_exception(long r3, long r4, long r5, long r6, long r7, long r8, unsigned long r0, struct pt_regs *regs);
+notrace unsigned long syscall_exit_prepare(unsigned long r3, struct pt_regs *regs);
+notrace unsigned long interrupt_exit_user_prepare(struct pt_regs *regs, unsigned long msr);
+notrace unsigned long interrupt_exit_kernel_prepare(struct pt_regs *regs, unsigned long msr);
+#endif
long ppc_fadvise64_64(int fd, int advice, u32 offset_high, u32 offset_low,
u32 len_high, u32 len_low);
diff --git a/arch/powerpc/kernel/syscall_64.c b/arch/powerpc/kernel/syscall_64.c
index d00cfc4a39a9..62f44c3072f3 100644
--- a/arch/powerpc/kernel/syscall_64.c
+++ b/arch/powerpc/kernel/syscall_64.c
@@ -1,4 +1,5 @@
#include <linux/err.h>
+#include <asm/asm-prototypes.h>
#include <asm/book3s/64/kup-radix.h>
#include <asm/cputime.h>
#include <asm/hw_irq.h>
--
2.23.0
next prev parent reply other threads:[~2019-11-27 10:40 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 10:38 [PATCH v2 rebase 00/34] exception cleanup, syscall in C and !COMPAT Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 01/34] powerpc/64s/exception: Introduce INT_DEFINE parameter block for code generation Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 02/34] powerpc/64s/exception: Add GEN_COMMON macro that uses INT_DEFINE parameters Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 03/34] powerpc/64s/exception: Add GEN_KVM " Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 04/34] powerpc/64s/exception: Expand EXC_COMMON and EXC_COMMON_ASYNC macros Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 05/34] powerpc/64s/exception: Move all interrupt handlers to new style code gen macros Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 06/34] powerpc/64s/exception: Remove old INT_ENTRY macro Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 07/34] powerpc/64s/exception: Remove old INT_COMMON macro Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 08/34] powerpc/64s/exception: Remove old INT_KVM_HANDLER Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 09/34] powerpc/64s/exception: Add ISIDE option Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 10/34] powerpc/64s/exception: move real->virt switch into the common handler Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 11/34] powerpc/64s/exception: move soft-mask test to common code Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 12/34] powerpc/64s/exception: move KVM " Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 13/34] powerpc/64s/exception: remove confusing IEARLY option Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 14/34] powerpc/64s/exception: remove the SPR saving patch code macros Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 15/34] powerpc/64s/exception: trim unused arguments from KVMTEST macro Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 16/34] powerpc/64s/exception: hdecrementer avoid touching the stack Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 17/34] powerpc/64s/exception: re-inline some handlers Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 18/34] powerpc/64s/exception: Clean up SRR specifiers Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 19/34] powerpc/64s/exception: add more comments for interrupt handlers Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 20/34] powerpc/64s/exception: only test KVM in SRR interrupts when PR KVM is supported Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 21/34] powerpc/64s/exception: soft nmi interrupt should not use ret_from_except Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 22/34] powerpc/64: system call remove non-volatile GPR save optimisation Michal Suchanek
2019-11-27 10:38 ` [PATCH v2 rebase 23/34] powerpc/64: system call implement the bulk of the logic in C Michal Suchanek
2019-11-27 10:39 ` [PATCH v2 rebase 24/34] powerpc/64s: interrupt return " Michal Suchanek
2019-11-27 10:39 ` [PATCH v2 rebase 25/34] powerpc/64s/exception: remove lite interrupt return Michal Suchanek
2019-11-27 10:39 ` Michal Suchanek [this message]
2019-11-27 10:39 ` [PATCH v2 rebase 27/34] powerpc: Add back __ARCH_WANT_SYS_LLSEEK macro Michal Suchanek
2019-11-27 10:39 ` [PATCH v2 rebase 28/34] powerpc: move common register copy functions from signal_32.c to signal.c Michal Suchanek
2019-11-27 10:39 ` [PATCH v2 rebase 29/34] powerpc/perf: consolidate read_user_stack_32 Michal Suchanek
2019-11-27 10:39 ` [PATCH v2 rebase 30/34] powerpc/perf: consolidate valid_user_sp Michal Suchanek
2019-11-27 10:39 ` [PATCH v2 rebase 31/34] powerpc/64: make buildable without CONFIG_COMPAT Michal Suchanek
2019-11-27 10:39 ` [PATCH v2 rebase 32/34] powerpc/64: Make COMPAT user-selectable disabled on littleendian by default Michal Suchanek
2019-11-27 10:39 ` [PATCH v2 rebase 33/34] powerpc/perf: split callchain.c by bitness Michal Suchanek
2019-11-27 10:39 ` [PATCH v2 rebase 34/34] MAINTAINERS: perf: Add pattern that matches ppc perf to the perf entry Michal Suchanek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f45bdb3ccb7c6a0c7ee5ff0612a80bce2f44dc0b.1574803685.git.msuchanek@suse.de \
--to=msuchanek@suse.de \
--cc=akpm@linux-foundation.org \
--cc=allison@lohutok.net \
--cc=andrew.donnellan@au1.ibm.com \
--cc=arnd@arndb.de \
--cc=benh@kernel.crashing.org \
--cc=brajeswar.linux@gmail.com \
--cc=cclaudio@linux.ibm.com \
--cc=christian@brauner.io \
--cc=christophe.leroy@c-s.fr \
--cc=david@redhat.com \
--cc=dhowells@redhat.com \
--cc=diana.craciun@nxp.com \
--cc=dja@axtens.net \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=firoz.khan@linaro.org \
--cc=geert@linux-m68k.org \
--cc=gregkh@linuxfoundation.org \
--cc=gromero@linux.ibm.com \
--cc=hbathini@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jagdsh.linux@gmail.com \
--cc=leitao@debian.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=maddy@linux.vnet.ibm.com \
--cc=mahesh@linux.vnet.ibm.com \
--cc=malat@debian.org \
--cc=mikey@neuling.org \
--cc=mpe@ellerman.id.au \
--cc=naveen.n.rao@linux.vnet.ibm.com \
--cc=npiggin@gmail.com \
--cc=nstange@suse.de \
--cc=oleg@redhat.com \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=ruscur@russell.cc \
--cc=tglx@linutronix.de \
--cc=valentin.schneider@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).