From: Fenghua Yu <fenghua.yu@intel.com>
To: "Thomas Gleixner" <tglx@linutronix.de>,
"Ingo Molnar" <mingo@redhat.com>,
"Borislav Petkov" <bp@alien8.de>, "H Peter Anvin" <hpa@zytor.com>,
"Tony Luck" <tony.luck@intel.com>,
"Reinette Chatre" <reinette.chatre@intel.com>,
"Babu Moger" <babu.moger@amd.com>,
"Andre Przywara" <Andre.Przywara@arm.com>,
"Sai Praneeth Prakhya" <sai.praneeth.prakhya@intel.com>,
"Ravi V Shankar" <ravi.v.shankar@intel.com>
Cc: "linux-kernel" <linux-kernel@vger.kernel.org>,
"x86" <x86@kernel.org>, Fenghua Yu <fenghua.yu@intel.com>
Subject: [PATCH v8 12/13] selftests/resctrl: Disable MBA and MBM tests for AMD
Date: Wed, 27 Nov 2019 16:39:43 -0800 [thread overview]
Message-ID: <1574901584-212957-13-git-send-email-fenghua.yu@intel.com> (raw)
In-Reply-To: <1574901584-212957-1-git-send-email-fenghua.yu@intel.com>
From: Babu Moger <babu.moger@amd.com>
For now, disable MBA and MBM tests for AMD. Deciding test pass/fail
is not clear right now. We can enable when we have some clarity.
Signed-off-by: Babu Moger <babu.moger@amd.com>
Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
---
tools/testing/selftests/resctrl/cat_test.c | 4 ++--
tools/testing/selftests/resctrl/resctrl_tests.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/tools/testing/selftests/resctrl/cat_test.c b/tools/testing/selftests/resctrl/cat_test.c
index c194fcc42407..5da43767b973 100644
--- a/tools/testing/selftests/resctrl/cat_test.c
+++ b/tools/testing/selftests/resctrl/cat_test.c
@@ -64,8 +64,8 @@ static void show_cache_info(unsigned long sum_llc_perf_miss, int no_of_bits,
allocated_cache_lines * 100;
printf("%sok CAT: cache miss rate within %d%%\n",
- abs((int)diff_percent) > MAX_DIFF_PERCENT ? "not " : "",
- MAX_DIFF_PERCENT);
+ !is_amd && abs((int)diff_percent) > MAX_DIFF_PERCENT ?
+ "not " : "", MAX_DIFF_PERCENT);
tests_run++;
printf("# Percent diff=%d\n", abs((int)diff_percent));
printf("# Number of bits: %d\n", no_of_bits);
diff --git a/tools/testing/selftests/resctrl/resctrl_tests.c b/tools/testing/selftests/resctrl/resctrl_tests.c
index 884e918b1e97..425cc85ac883 100644
--- a/tools/testing/selftests/resctrl/resctrl_tests.c
+++ b/tools/testing/selftests/resctrl/resctrl_tests.c
@@ -158,7 +158,7 @@ int main(int argc, char **argv)
check_resctrlfs_support();
filter_dmesg();
- if (mbm_test) {
+ if (!is_amd && mbm_test) {
printf("# Starting MBM BW change ...\n");
if (!has_ben)
sprintf(benchmark_cmd[5], "%s", "mba");
@@ -168,7 +168,7 @@ int main(int argc, char **argv)
tests_run++;
}
- if (mba_test) {
+ if (!is_amd && mba_test) {
printf("# Starting MBA Schemata change ...\n");
if (!has_ben)
sprintf(benchmark_cmd[1], "%d", span);
--
2.19.1
next prev parent reply other threads:[~2019-11-28 1:43 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-28 0:39 [PATCH v8 00/13] selftests/resctrl: Add resctrl selftest Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 01/13] selftests/resctrl: Add README for resctrl tests Fenghua Yu
2019-11-28 7:23 ` Borislav Petkov
2019-12-02 18:53 ` Fenghua Yu
2019-12-02 23:06 ` Borislav Petkov
2019-12-02 23:42 ` Fenghua Yu
2019-12-02 23:49 ` Borislav Petkov
2019-12-03 0:04 ` Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 02/13] selftests/resctrl: Add basic resctrl file system operations and data Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 03/13] selftests/resctrl: Read memory bandwidth from perf IMC counter and from resctrl file system Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 04/13] selftests/resctrl: Add callback to start a benchmark Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 05/13] selftests/resctrl: Add built in benchmark Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 06/13] selftests/resctrl: Add MBM test Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 07/13] selftests/resctrl: Add MBA test Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 08/13] selftests/resctrl: Add Cache QoS Monitoring (CQM) selftest Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 09/13] selftests/resctrl: Add Cache Allocation Technology (CAT) selftest Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 10/13] selftests/resctrl: Add vendor detection mechanism Fenghua Yu
2019-11-28 0:39 ` [PATCH v8 11/13] selftests/resctrl: Use cache index3 id for AMD schemata masks Fenghua Yu
2019-11-28 0:39 ` Fenghua Yu [this message]
2019-11-28 0:39 ` [PATCH v8 13/13] selftests/resctrl: Add the test in MAINTAINERS Fenghua Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1574901584-212957-13-git-send-email-fenghua.yu@intel.com \
--to=fenghua.yu@intel.com \
--cc=Andre.Przywara@arm.com \
--cc=babu.moger@amd.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=ravi.v.shankar@intel.com \
--cc=reinette.chatre@intel.com \
--cc=sai.praneeth.prakhya@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).