From: Ikjoon Jang <ikjn@chromium.org>
To: linux-usb@vger.kernel.org
Cc: GregKroah-Hartman <gregkh@linuxfoundation.org>,
RobHerring <robh+dt@kernel.org>,
MarkRutland <mark.rutland@arm.com>,
AlanStern <stern@rowland.harvard.edu>,
SuwanKim <suwan.kim027@gmail.com>,
"GustavoA . R . Silva" <gustavo@embeddedor.com>,
IkjoonJang <ikjn@chromium.org>, JohanHovold <johan@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
drinkcat@chromium.org
Subject: [PATCH v4 2/2] usb: overridable hub bInterval by device node
Date: Tue, 3 Dec 2019 18:15:52 +0800 [thread overview]
Message-ID: <20191203101552.199339-1-ikjn@chromium.org> (raw)
This patch enables hub device to override its own endpoint descriptor's
bInterval when the hub has a device node with "hub,interval" property.
When we know reducing autosuspend delay for built-in HIDs is better for
power saving, we can reduce it to the optimal value. But if a parent hub
has a long bInterval, mouse lags a lot from more frequent autosuspend.
So this enables overriding bInterval for a hard wired hub device only
when we know that reduces the power consumption.
Signed-off-by: Ikjoon Jang <ikjn@chromium.org>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
---
drivers/usb/core/config.c | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/drivers/usb/core/config.c b/drivers/usb/core/config.c
index 5f40117e68e7..95ec5af42a1c 100644
--- a/drivers/usb/core/config.c
+++ b/drivers/usb/core/config.c
@@ -6,6 +6,7 @@
#include <linux/usb.h>
#include <linux/usb/ch9.h>
#include <linux/usb/hcd.h>
+#include <linux/usb/of.h>
#include <linux/usb/quirks.h>
#include <linux/module.h>
#include <linux/slab.h>
@@ -257,6 +258,14 @@ static int usb_parse_endpoint(struct device *ddev, int cfgno, int inum,
memcpy(&endpoint->desc, d, n);
INIT_LIST_HEAD(&endpoint->urb_list);
+ /* device node property overrides bInterval */
+ if (usb_of_has_combined_node(to_usb_device(ddev))) {
+ u32 interval = 0;
+ if (!of_property_read_u32(ddev->of_node, "hub,interval",
+ &interval))
+ d->bInterval = min_t(u8, interval, 255);
+ }
+
/*
* Fix up bInterval values outside the legal range.
* Use 10 or 8 ms if no proper value can be guessed.
--
2.24.0.393.g34dc348eaf-goog
next reply other threads:[~2019-12-03 10:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 10:15 Ikjoon Jang [this message]
2019-12-03 15:23 ` [PATCH v4 2/2] usb: overridable hub bInterval by device node Alan Stern
2019-12-04 7:07 ` Ikjoon Jang
2019-12-03 16:53 ` Johan Hovold
2019-12-04 7:04 ` Ikjoon Jang
2019-12-04 7:55 ` Johan Hovold
2019-12-05 7:32 ` Ikjoon Jang
2019-12-05 14:26 ` Johan Hovold
2019-12-06 3:57 ` Ikjoon Jang
2019-12-06 15:00 ` Alan Stern
2019-12-09 3:47 ` Ikjoon Jang
2019-12-06 15:26 ` Johan Hovold
2019-12-09 4:05 ` Ikjoon Jang
2019-12-10 15:02 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191203101552.199339-1-ikjn@chromium.org \
--to=ikjn@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=drinkcat@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=stern@rowland.harvard.edu \
--cc=suwan.kim027@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).