From: Stefan Nuernberger <snu@amazon.com>
To: <linux-kernel@vger.kernel.org>
Cc: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Juergen Gross <jgross@suse.com>,
Ross Lagerwall <ross.lagerwall@citrix.com>,
Uwe Dannowski <uwed@amazon.de>, Conny Seidel <consei@amazon.de>,
Stefan Nuernberger <snu@amazon.com>,
<xen-devel@lists.xenproject.org>, <stable@vger.kernel.org>
Subject: [PATCH] xen/pciback: Prevent NULL pointer dereference in quirks_show
Date: Fri, 6 Dec 2019 14:48:04 +0100 [thread overview]
Message-ID: <20191206134804.4537-1-snu@amazon.com> (raw)
From: Uwe Dannowski <uwed@amazon.de>
Reading /sys/bus/pci/drivers/pciback/quirks while unbinding can result
in dereferencing a NULL pointer. Instead, skip printing information
about the dangling quirk.
Reported-by: Conny Seidel <consei@amazon.de>
Signed-off-by: Uwe Dannowski <uwed@amazon.de>
Signed-off-by: Stefan Nuernberger <snu@amazon.com>
Cc: xen-devel@lists.xenproject.org
Cc: stable@vger.kernel.org
---
drivers/xen/xen-pciback/pci_stub.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/xen/xen-pciback/pci_stub.c b/drivers/xen/xen-pciback/pci_stub.c
index 097410a7cdb7..da725e474294 100644
--- a/drivers/xen/xen-pciback/pci_stub.c
+++ b/drivers/xen/xen-pciback/pci_stub.c
@@ -1346,6 +1346,8 @@ static ssize_t quirks_show(struct device_driver *drv, char *buf)
quirk->devid.subdevice);
dev_data = pci_get_drvdata(quirk->pdev);
+ if (!dev_data)
+ continue;
list_for_each_entry(cfg_entry, &dev_data->config_fields, list) {
field = cfg_entry->field;
--
2.23.0
Amazon Development Center Germany GmbH
Krausenstr. 38
10117 Berlin
Geschaeftsfuehrung: Christian Schlaeger, Ralf Herbrich
Eingetragen am Amtsgericht Charlottenburg unter HRB 149173 B
Sitz: Berlin
Ust-ID: DE 289 237 879
next reply other threads:[~2019-12-06 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 13:48 Stefan Nuernberger [this message]
2019-12-06 15:11 ` [PATCH] xen/pciback: Prevent NULL pointer dereference in quirks_show Boris Ostrovsky
2019-12-06 18:09 ` Nuernberger, Stefan
2019-12-06 20:15 ` Boris Ostrovsky
2019-12-09 18:16 ` Nuernberger, Stefan
2019-12-09 21:21 ` Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191206134804.4537-1-snu@amazon.com \
--to=snu@amazon.com \
--cc=boris.ostrovsky@oracle.com \
--cc=consei@amazon.de \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ross.lagerwall@citrix.com \
--cc=stable@vger.kernel.org \
--cc=uwed@amazon.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).