linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Hubbard <jhubbard@nvidia.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: "Al Viro" <viro@zeniv.linux.org.uk>,
	"Alex Williamson" <alex.williamson@redhat.com>,
	"Benjamin Herrenschmidt" <benh@kernel.crashing.org>,
	"Björn Töpel" <bjorn.topel@intel.com>,
	"Christoph Hellwig" <hch@infradead.org>,
	"Dan Williams" <dan.j.williams@intel.com>,
	"Daniel Vetter" <daniel@ffwll.ch>,
	"Dave Chinner" <david@fromorbit.com>,
	"David Airlie" <airlied@linux.ie>,
	"David S . Miller" <davem@davemloft.net>,
	"Ira Weiny" <ira.weiny@intel.com>, "Jan Kara" <jack@suse.cz>,
	"Jason Gunthorpe" <jgg@ziepe.ca>, "Jens Axboe" <axboe@kernel.dk>,
	"Jonathan Corbet" <corbet@lwn.net>,
	"Jérôme Glisse" <jglisse@redhat.com>,
	"Magnus Karlsson" <magnus.karlsson@intel.com>,
	"Mauro Carvalho Chehab" <mchehab@kernel.org>,
	"Michael Ellerman" <mpe@ellerman.id.au>,
	"Michal Hocko" <mhocko@suse.com>,
	"Mike Kravetz" <mike.kravetz@oracle.com>,
	"Paul Mackerras" <paulus@samba.org>,
	"Shuah Khan" <shuah@kernel.org>,
	"Vlastimil Babka" <vbabka@suse.cz>,
	bpf@vger.kernel.org, dri-devel@lists.freedesktop.org,
	kvm@vger.kernel.org, linux-block@vger.kernel.org,
	linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org,
	linux-rdma@vger.kernel.org, linuxppc-dev@lists.ozlabs.org,
	netdev@vger.kernel.org, linux-mm@kvack.org,
	LKML <linux-kernel@vger.kernel.org>,
	"John Hubbard" <jhubbard@nvidia.com>
Subject: [PATCH v8 16/26] net/xdp: set FOLL_PIN via pin_user_pages()
Date: Mon, 9 Dec 2019 14:53:34 -0800	[thread overview]
Message-ID: <20191209225344.99740-17-jhubbard@nvidia.com> (raw)
In-Reply-To: <20191209225344.99740-1-jhubbard@nvidia.com>

Convert net/xdp to use the new pin_longterm_pages() call, which sets
FOLL_PIN. Setting FOLL_PIN is now required for code that requires
tracking of pinned pages.

In partial anticipation of this work, the net/xdp code was already
calling put_user_page() instead of put_page(). Therefore, in order to
convert from the get_user_pages()/put_page() model, to the
pin_user_pages()/put_user_page() model, the only change required
here is to change get_user_pages() to pin_user_pages().

Acked-by: Björn Töpel <bjorn.topel@intel.com>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---
 net/xdp/xdp_umem.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/xdp/xdp_umem.c b/net/xdp/xdp_umem.c
index 3049af269fbf..d071003b5e76 100644
--- a/net/xdp/xdp_umem.c
+++ b/net/xdp/xdp_umem.c
@@ -291,7 +291,7 @@ static int xdp_umem_pin_pages(struct xdp_umem *umem)
 		return -ENOMEM;
 
 	down_read(&current->mm->mmap_sem);
-	npgs = get_user_pages(umem->address, umem->npgs,
+	npgs = pin_user_pages(umem->address, umem->npgs,
 			      gup_flags | FOLL_LONGTERM, &umem->pgs[0], NULL);
 	up_read(&current->mm->mmap_sem);
 
-- 
2.24.0


  parent reply	other threads:[~2019-12-09 22:57 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-09 22:53 [PATCH v8 00/26] mm/gup: track dma-pinned pages: FOLL_PIN John Hubbard
2019-12-09 22:53 ` [PATCH v8 01/26] mm/gup: factor out duplicate code from four routines John Hubbard
2019-12-09 22:53 ` [PATCH v8 02/26] mm/gup: move try_get_compound_head() to top, fix minor issues John Hubbard
2019-12-09 22:53 ` [PATCH v8 03/26] mm: Cleanup __put_devmap_managed_page() vs ->page_free() John Hubbard
2019-12-09 22:53 ` [PATCH v8 04/26] mm: devmap: refactor 1-based refcounting for ZONE_DEVICE pages John Hubbard
2019-12-09 22:53 ` [PATCH v8 05/26] goldish_pipe: rename local pin_user_pages() routine John Hubbard
2019-12-09 22:53 ` [PATCH v8 06/26] mm: fix get_user_pages_remote()'s handling of FOLL_LONGTERM John Hubbard
2019-12-09 22:53 ` [PATCH v8 07/26] vfio: fix FOLL_LONGTERM use, simplify get_user_pages_remote() call John Hubbard
2019-12-09 22:53 ` [PATCH v8 08/26] mm/gup: allow FOLL_FORCE for get_user_pages_fast() John Hubbard
2019-12-10 10:28   ` Jan Kara
2019-12-09 22:53 ` [PATCH v8 09/26] IB/umem: use get_user_pages_fast() to pin DMA pages John Hubbard
2019-12-09 22:53 ` [PATCH v8 10/26] mm/gup: introduce pin_user_pages*() and FOLL_PIN John Hubbard
2019-12-09 22:53 ` [PATCH v8 11/26] goldish_pipe: convert to pin_user_pages() and put_user_page() John Hubbard
2019-12-09 22:53 ` [PATCH v8 12/26] IB/{core,hw,umem}: set FOLL_PIN via pin_user_pages*(), fix up ODP John Hubbard
2019-12-09 22:53 ` [PATCH v8 13/26] mm/process_vm_access: set FOLL_PIN via pin_user_pages_remote() John Hubbard
2019-12-09 22:53 ` [PATCH v8 14/26] drm/via: set FOLL_PIN via pin_user_pages_fast() John Hubbard
2019-12-09 22:53 ` [PATCH v8 15/26] fs/io_uring: set FOLL_PIN via pin_user_pages() John Hubbard
2019-12-09 22:53 ` John Hubbard [this message]
2019-12-09 22:53 ` [PATCH v8 17/26] media/v4l2-core: set pages dirty upon releasing DMA buffers John Hubbard
2019-12-10  0:56   ` Andrew Morton
2019-12-10  5:48     ` John Hubbard
2019-12-10 10:17     ` Jan Kara
2019-12-09 22:53 ` [PATCH v8 18/26] media/v4l2-core: pin_user_pages (FOLL_PIN) and put_user_page() conversion John Hubbard
2019-12-09 22:53 ` [PATCH v8 19/26] vfio, mm: " John Hubbard
2019-12-09 22:53 ` [PATCH v8 20/26] powerpc: book3s64: convert to pin_user_pages() and put_user_page() John Hubbard
2019-12-09 23:46   ` John Hubbard
2019-12-10  5:53     ` John Hubbard
2019-12-11  0:49       ` Andrew Morton
2019-12-09 22:53 ` [PATCH v8 21/26] mm/gup_benchmark: use proper FOLL_WRITE flags instead of hard-coding "1" John Hubbard
2019-12-09 22:53 ` [PATCH v8 22/26] mm, tree-wide: rename put_user_page*() to unpin_user_page*() John Hubbard
2019-12-09 22:53 ` [PATCH v8 23/26] mm/gup: pass flags arg to __gup_device_* functions John Hubbard
2019-12-10 12:49   ` Jan Kara
2019-12-11  0:27     ` John Hubbard
2019-12-09 22:53 ` [PATCH v8 24/26] mm/gup: track FOLL_PIN pages John Hubbard
2019-12-10 13:39   ` Jan Kara
2019-12-11  0:27     ` John Hubbard
2019-12-09 22:53 ` [PATCH v8 25/26] mm/gup_benchmark: support pin_user_pages() and related calls John Hubbard
2019-12-09 22:53 ` [PATCH v8 26/26] selftests/vm: run_vmtests: invoke gup_benchmark with basic FOLL_PIN coverage John Hubbard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191209225344.99740-17-jhubbard@nvidia.com \
    --to=jhubbard@nvidia.com \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=alex.williamson@redhat.com \
    --cc=axboe@kernel.dk \
    --cc=benh@kernel.crashing.org \
    --cc=bjorn.topel@intel.com \
    --cc=bpf@vger.kernel.org \
    --cc=corbet@lwn.net \
    --cc=dan.j.williams@intel.com \
    --cc=daniel@ffwll.ch \
    --cc=davem@davemloft.net \
    --cc=david@fromorbit.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=hch@infradead.org \
    --cc=ira.weiny@intel.com \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=magnus.karlsson@intel.com \
    --cc=mchehab@kernel.org \
    --cc=mhocko@suse.com \
    --cc=mike.kravetz@oracle.com \
    --cc=mpe@ellerman.id.au \
    --cc=netdev@vger.kernel.org \
    --cc=paulus@samba.org \
    --cc=shuah@kernel.org \
    --cc=vbabka@suse.cz \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).