From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Yoshinori Sato <ysato@users.sourceforge.jp>,
Rich Felker <dalias@libc.org>,
Daniel Thompson <daniel.thompson@linaro.org>,
Will Deacon <will@kernel.org>,
Douglas Anderson <dianders@chromium.org>,
Paul Burton <paul.burton@mips.com>,
Christophe Leroy <christophe.leroy@c-s.fr>,
linux-sh@vger.kernel.org, linux-kernel@vger.kernel.org,
Daniel Thompson <daniel.thompson@linaro.org>
Subject: [PATCH] sh: kgdb: Mark expected switch fall-throughs
Date: 10 Dec 2019 09:27:45 +0900 [thread overview]
Message-ID: <87lfrlyqgu.wl-kuninori.morimoto.gx@renesas.com> (raw)
In-Reply-To: <87muc1yqip.wl-kuninori.morimoto.gx@renesas.com>
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Mark switch cases where we are expecting to fall through.
This patch fixes the following error:
LINUX/arch/sh/kernel/kgdb.c: In function 'kgdb_arch_handle_exception':
LINUX/arch/sh/kernel/kgdb.c:267:6: error: this statement may fall through [-Werror=implicit-fallthrough=]
if (kgdb_hex2long(&ptr, &addr))
^
LINUX/arch/sh/kernel/kgdb.c:269:2: note: here
case 'D':
^~~~
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
---
arch/sh/kernel/kgdb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/sh/kernel/kgdb.c b/arch/sh/kernel/kgdb.c
index 6d61f8c..0d5f3c9 100644
--- a/arch/sh/kernel/kgdb.c
+++ b/arch/sh/kernel/kgdb.c
@@ -266,6 +266,7 @@ int kgdb_arch_handle_exception(int e_vector, int signo, int err_code,
ptr = &remcomInBuffer[1];
if (kgdb_hex2long(&ptr, &addr))
linux_regs->pc = addr;
+ /* fallthrough */
case 'D':
case 'k':
atomic_set(&kgdb_cpu_doing_single_step, -1);
--
2.7.4
next prev parent reply other threads:[~2019-12-10 0:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 0:26 [PATCH][resend] sh: kgdb: Mark expected switch fall-throughs Kuninori Morimoto
2019-12-10 0:27 ` Kuninori Morimoto [this message]
2019-12-10 8:17 ` Geert Uytterhoeven
2019-12-10 8:19 ` Kuninori Morimoto
2019-12-10 20:10 ` Rob Landley
-- strict thread matches above, loose matches on Subject: below --
2019-12-10 8:38 Kuninori Morimoto
2019-12-10 8:39 ` [PATCH] " Kuninori Morimoto
2019-12-10 8:47 ` Christophe Leroy
2019-12-11 15:18 ` Daniel Thompson
2019-10-30 7:17 Kuninori Morimoto
2019-10-30 8:44 ` Daniel Thompson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfrlyqgu.wl-kuninori.morimoto.gx@renesas.com \
--to=kuninori.morimoto.gx@renesas.com \
--cc=christophe.leroy@c-s.fr \
--cc=dalias@libc.org \
--cc=daniel.thompson@linaro.org \
--cc=dianders@chromium.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=paul.burton@mips.com \
--cc=will@kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).