From: Jim Cromie <jim.cromie@gmail.com>
To: jbaron@akamai.com, linux-kernel@vger.kernel.org,
akpm@linuxfoundation.org
Cc: gregkh@linuxfoundation.org, linux@rasmusvillemoes.dk,
Jim Cromie <jim.cromie@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
Jessica Yu <jeyu@kernel.org>,
linux-arch@vger.kernel.org
Subject: [PATCH v4 04/16] dyndbg: rename __verbose section to __dyndbg
Date: Mon, 9 Dec 2019 19:27:30 -0700 [thread overview]
Message-ID: <20191210022742.822686-5-jim.cromie@gmail.com> (raw)
In-Reply-To: <20191210022742.822686-1-jim.cromie@gmail.com>
dyndbg populates its callsite info into __verbose section, change that
to a more specific and descriptive name, __dyndbg.
Also, per checkpatch:
simplify __attribute(..) to __section(__dyndbg) declaration.
and 1 spelling fix
Signed-off-by: Jim Cromie <jim.cromie@gmail.com>
---
include/asm-generic/vmlinux.lds.h | 6 +++---
include/linux/dynamic_debug.h | 4 ++--
kernel/module.c | 2 +-
lib/dynamic_debug.c | 12 ++++++------
4 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index dae64600ccbf..82694efe3a83 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -285,9 +285,9 @@
*(__tracepoints) \
/* implement dynamic printk debug */ \
. = ALIGN(8); \
- __start___verbose = .; \
- KEEP(*(__verbose)) \
- __stop___verbose = .; \
+ __start___dyndbg = .; \
+ KEEP(*(__dyndbg)) \
+ __stop___dyndbg = .; \
LIKELY_PROFILE() \
BRANCH_PROFILE() \
TRACE_PRINTKS() \
diff --git a/include/linux/dynamic_debug.h b/include/linux/dynamic_debug.h
index 4cf02ecd67de..802480ea8708 100644
--- a/include/linux/dynamic_debug.h
+++ b/include/linux/dynamic_debug.h
@@ -80,7 +80,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
#define DEFINE_DYNAMIC_DEBUG_METADATA(name, fmt) \
static struct _ddebug __aligned(8) \
- __attribute__((section("__verbose"))) name = { \
+ __section(__dyndbg) name = { \
.modname = KBUILD_MODNAME, \
.function = __func__, \
.filename = __FILE__, \
@@ -133,7 +133,7 @@ void __dynamic_ibdev_dbg(struct _ddebug *descriptor,
/*
* "Factory macro" for generating a call to func, guarded by a
- * DYNAMIC_DEBUG_BRANCH. The dynamic debug decriptor will be
+ * DYNAMIC_DEBUG_BRANCH. The dynamic debug descriptor will be
* initialized using the fmt argument. The function will be called with
* the address of the descriptor as first argument, followed by all
* the varargs. Note that fmt is repeated in invocations of this
diff --git a/kernel/module.c b/kernel/module.c
index ff2d7359a418..a9c052cc30c5 100644
--- a/kernel/module.c
+++ b/kernel/module.c
@@ -3237,7 +3237,7 @@ static int find_module_sections(struct module *mod, struct load_info *info)
if (section_addr(info, "__obsparm"))
pr_warn("%s: Ignoring obsolete parameters\n", mod->name);
- info->debug = section_objs(info, "__verbose",
+ info->debug = section_objs(info, "__dyndbg",
sizeof(*info->debug), &info->num_debug);
return 0;
diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index c86c97154657..0a4588fe342e 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -39,8 +39,8 @@
#include <rdma/ib_verbs.h>
-extern struct _ddebug __start___verbose[];
-extern struct _ddebug __stop___verbose[];
+extern struct _ddebug __start___dyndbg[];
+extern struct _ddebug __stop___dyndbg[];
struct ddebug_table {
struct list_head link;
@@ -1010,14 +1010,14 @@ static int __init dynamic_debug_init(void)
int n = 0, entries = 0, modct = 0;
int verbose_bytes = 0;
- if (__start___verbose == __stop___verbose) {
+ if (__start___dyndbg == __stop___dyndbg) {
pr_warn("_ddebug table is empty in a CONFIG_DYNAMIC_DEBUG build\n");
return 1;
}
- iter = __start___verbose;
+ iter = __start___dyndbg;
modname = iter->modname;
iter_start = iter;
- for (; iter < __stop___verbose; iter++) {
+ for (; iter < __stop___dyndbg; iter++) {
entries++;
verbose_bytes += strlen(iter->modname) + strlen(iter->function)
+ strlen(iter->filename) + strlen(iter->format);
@@ -1040,7 +1040,7 @@ static int __init dynamic_debug_init(void)
ddebug_init_success = 1;
vpr_info("%d modules, %d entries and %d bytes in ddebug tables, %d bytes in (readonly) verbose section\n",
modct, entries, (int)(modct * sizeof(struct ddebug_table)),
- verbose_bytes + (int)(__stop___verbose - __start___verbose));
+ verbose_bytes + (int)(__stop___dyndbg - __start___dyndbg));
/* apply ddebug_query boot param, dont unload tables on err */
if (ddebug_setup_string[0] != '\0') {
--
2.23.0
next prev parent reply other threads:[~2019-12-10 2:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 2:27 [PATCH v4 00/16] dynamic-debug cleanups, 2 new features Jim Cromie
2019-12-10 2:27 ` [PATCH v4 01/16] dyndbg-docs: eschew file /full/path query in docs Jim Cromie
2019-12-10 2:27 ` [PATCH v4 02/16] dyndbg: drop obsolete comment on ddebug_proc_open Jim Cromie
2019-12-10 2:27 ` [PATCH v4 03/16] dyndbg: raise verbosity needed to enable ddebug_proc_* logging Jim Cromie
2019-12-10 2:27 ` Jim Cromie [this message]
2019-12-10 2:27 ` [PATCH v4 05/16] dyndbg: fix overcounting of ram used by dyndbg Jim Cromie
2019-12-10 2:27 ` [PATCH v4 06/16] dyndbg: fix a BUG_ON in ddebug_describe_flags Jim Cromie
2019-12-10 19:58 ` Jason Baron
2019-12-13 1:35 ` jim.cromie
2019-12-10 2:27 ` [PATCH v4 07/16] dyndbg: refactor parse_linerange out of ddebug_parse_query Jim Cromie
2019-12-10 2:27 ` [PATCH v4 08/16] dyndbg: accept 'file foo.c:func1' and 'file foo.c:10-100' Jim Cromie
2019-12-10 2:27 ` [PATCH v4 09/16] dyndbg: refactor ddebug_read_flags out of ddebug_parse_flags Jim Cromie
2019-12-10 2:27 ` [PATCH v4 10/16] dyndbg: combine flags & mask into a struct, use that Jim Cromie
2019-12-10 2:27 ` [PATCH v4 11/16] dyndbg: add filter parameter to ddebug_parse_flags Jim Cromie
2019-12-10 2:27 ` [PATCH v4 12/16] dyndbg: extend ddebug_parse_flags to accept optional filter-flags Jim Cromie
2019-12-10 2:27 ` [PATCH v4 13/16] dyndbg: prefer declarative init in caller, to memset in callee Jim Cromie
2019-12-10 2:27 ` [PATCH v4 14/16] dyndbg: add user-flag, negating-flags, and filtering on flags Jim Cromie
2019-12-10 2:27 ` [PATCH v4 15/16] dyndbg: allow negating flag-chars in modflags Jim Cromie
2019-12-10 2:27 ` [PATCH v4 16/16] dyndbg: make ddebug_tables list LIFO for add/remove_module Jim Cromie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210022742.822686-5-jim.cromie@gmail.com \
--to=jim.cromie@gmail.com \
--cc=akpm@linuxfoundation.org \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jbaron@akamai.com \
--cc=jeyu@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).