[tip/core/rcu,09/11] rcu: Use READ_ONCE() for ->expmask in rcu_read_unlock_special()
diff mbox series

Message ID 20191210042629.3808-9-paulmck@kernel.org
State Accepted
Commit c51f83c315c392d9776c33eb16a2fe1349d65c7f
Headers show
  • Preemptible-RCU updates for v5.6
Related show

Commit Message

Paul E. McKenney Dec. 10, 2019, 4:26 a.m. UTC
From: "Paul E. McKenney" <paulmck@kernel.org>

The rcu_node structure's ->expmask field is updated only when holding the
->lock, but is also accessed locklessly.  This means that all ->expmask
updates must use WRITE_ONCE() and all reads carried out without holding
->lock must use READ_ONCE().  This commit therefore changes the lockless
->expmask read in rcu_read_unlock_special() to use READ_ONCE().

Reported-by: syzbot+99f4ddade3c22ab0cf23@syzkaller.appspotmail.com
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>
Acked-by: Marco Elver <elver@google.com>
 kernel/rcu/tree_plugin.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h
index c3a3271..698a7f1 100644
--- a/kernel/rcu/tree_plugin.h
+++ b/kernel/rcu/tree_plugin.h
@@ -599,7 +599,7 @@  static void rcu_read_unlock_special(struct task_struct *t)
 		struct rcu_node *rnp = rdp->mynode;
 		exp = (t->rcu_blocked_node && t->rcu_blocked_node->exp_tasks) ||
-		      (rdp->grpmask & rnp->expmask) ||
+		      (rdp->grpmask & READ_ONCE(rnp->expmask)) ||
 		// Need to defer quiescent state until everything is enabled.
 		if (irqs_were_disabled && use_softirq &&