From: Faiz Abbas <faiz_abbas@ti.com>
To: <linux-kernel@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-mmc@vger.kernel.org>
Cc: <kishon@ti.com>, <adrian.hunter@intel.com>,
<mark.rutland@arm.com>, <robh+dt@kernel.org>,
<ulf.hansson@linaro.org>, <zhang.chunyan@linaro.org>,
<tony@atomide.com>
Subject: [PATCH v3 4/7] mmc: sdhci: Add quirk for disabling DTO during erase command
Date: Tue, 10 Dec 2019 15:21:48 +0530 [thread overview]
Message-ID: <20191210095151.15441-5-faiz_abbas@ti.com> (raw)
In-Reply-To: <20191210095151.15441-1-faiz_abbas@ti.com>
Some controllers might prematurely issue a data timeout during an erase
command. Add a quirk to disable the interrupt when an erase command is
issued.
Signed-off-by: Faiz Abbas <faiz_abbas@ti.com>
---
drivers/mmc/host/sdhci.c | 5 +++++
drivers/mmc/host/sdhci.h | 2 ++
2 files changed, 7 insertions(+)
diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c
index 6f3d4991bee1..b8934c50b9c4 100644
--- a/drivers/mmc/host/sdhci.c
+++ b/drivers/mmc/host/sdhci.c
@@ -1532,6 +1532,11 @@ void sdhci_send_command(struct sdhci_host *host, struct mmc_command *cmd)
/* Initially, a command has no error */
cmd->error = 0;
+ if (cmd->opcode == MMC_ERASE &&
+ (host->quirks2 & SDHCI_QUIRK2_DISABLE_DTO_FOR_ERASE)) {
+ sdhci_set_data_timeout_irq(host, false);
+ }
+
if ((host->quirks2 & SDHCI_QUIRK2_STOP_WITH_TC) &&
cmd->opcode == MMC_STOP_TRANSMISSION)
cmd->flags |= MMC_RSP_BUSY;
diff --git a/drivers/mmc/host/sdhci.h b/drivers/mmc/host/sdhci.h
index b28706a1bc6f..beda9afba3a6 100644
--- a/drivers/mmc/host/sdhci.h
+++ b/drivers/mmc/host/sdhci.h
@@ -482,6 +482,8 @@ struct sdhci_host {
* block count.
*/
#define SDHCI_QUIRK2_USE_32BIT_BLK_CNT (1<<18)
+/* Controller needs to disable DTO for erase command */
+#define SDHCI_QUIRK2_DISABLE_DTO_FOR_ERASE (1<<19)
int irq; /* Device IRQ */
void __iomem *ioaddr; /* Mapped address */
--
2.19.2
next prev parent reply other threads:[~2019-12-10 9:51 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-10 9:51 [PATCH v3 0/7] Port am335 and am437 devices to sdhci-omap Faiz Abbas
2019-12-10 9:51 ` [PATCH v3 1/7] dt-bindings: sdhci-omap: Add properties for using external dma Faiz Abbas
2019-12-18 21:39 ` Rob Herring
2019-12-10 9:51 ` [PATCH v3 2/7] mmc: sdhci: add support for using external DMA devices Faiz Abbas
2019-12-12 12:55 ` Adrian Hunter
2019-12-16 8:27 ` Faiz Abbas
2019-12-16 13:45 ` Adrian Hunter
2019-12-23 14:25 ` Faiz Abbas
2019-12-10 9:51 ` [PATCH v3 3/7] mmc: sdhci-omap: Add using external dma Faiz Abbas
2019-12-10 9:51 ` Faiz Abbas [this message]
2019-12-13 9:40 ` [PATCH v3 4/7] mmc: sdhci: Add quirk for disabling DTO during erase command Adrian Hunter
2019-12-16 8:42 ` Faiz Abbas
2019-12-10 9:51 ` [PATCH v3 5/7] mmc: sdhci-omap: Add DISABLE_DTO_FOR_ERASE Quirk Faiz Abbas
2019-12-10 9:51 ` [PATCH v3 6/7] dt-bindings: sdhci-omap: Add am335x and am437x specific bindings Faiz Abbas
2019-12-10 9:51 ` [PATCH v3 7/7] mmc: sdhci-omap: Add am335x and am437x specific compatibles Faiz Abbas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191210095151.15441-5-faiz_abbas@ti.com \
--to=faiz_abbas@ti.com \
--cc=adrian.hunter@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
--cc=ulf.hansson@linaro.org \
--cc=zhang.chunyan@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).