broonie-sound/for-next bisection: boot on rk3399-gru-kevin
diff mbox series

Message ID 5def94e7.1c69fb81.2751f.190a@mx.google.com
State New
Headers show
Series
  • broonie-sound/for-next bisection: boot on rk3399-gru-kevin
Related show

Commit Message

kernelci.org bot Dec. 10, 2019, 12:51 p.m. UTC
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* This automated bisection report was sent to you on the basis  *
* that you may be involved with the breaking commit it has      *
* found.  No manual investigation has been done to verify it,   *
* and the root cause of the problem may be somewhere else.      *
*                                                               *
* If you do send a fix, please include this trailer:            *
*   Reported-by: "kernelci.org bot" <bot@kernelci.org>          *
*                                                               *
* Hope this helps!                                              *
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

broonie-sound/for-next bisection: boot on rk3399-gru-kevin

Summary:
  Start:      3778790e1d13 Merge branch 'asoc-5.6' into asoc-next
  Details:    https://kernelci.org/boot/id/5deef68acb72c66093960f08
  Plain log:  https://storage.kernelci.org//broonie-sound/for-next/v5.5-rc1-46-g3778790e1d13/arm64/defconfig/gcc-8/lab-collabora/boot-rk3399-gru-kevin.txt
  HTML log:   https://storage.kernelci.org//broonie-sound/for-next/v5.5-rc1-46-g3778790e1d13/arm64/defconfig/gcc-8/lab-collabora/boot-rk3399-gru-kevin.html
  Result:     abe3b6727b65 ASoC: cs42l51: add dac mux widget in codec routes

Checks:
  revert:     PASS
  verify:     PASS

Parameters:
  Tree:       broonie-sound
  URL:        https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
  Branch:     for-next
  Target:     rk3399-gru-kevin
  CPU arch:   arm64
  Lab:        lab-collabora
  Compiler:   gcc-8
  Config:     defconfig
  Test suite: boot

Breaking commit found:

-------------------------------------------------------------------------------
commit abe3b6727b653307c27870a2d4ecbf9de4e914a5
Author: Olivier Moysan <olivier.moysan@st.com>
Date:   Tue Dec 3 15:16:27 2019 +0100

    ASoC: cs42l51: add dac mux widget in codec routes
    
    Add "DAC mux" DAPM widget in CS42l51 audio codec routes,
    to support DAC mux control and to remove error trace
    "DAC Mux has no paths" at widget creation.
    Note: ADC path of DAC mux is not routed in this patch.
    
    Signed-off-by: Olivier Moysan <olivier.moysan@st.com>
    Link: https://lore.kernel.org/r/20191203141627.29471-1-olivier.moysan@st.com
    Signed-off-by: Mark Brown <broonie@kernel.org>


Git bisection log:

-------------------------------------------------------------------------------
git bisect start
# good: [e42617b825f8073569da76dc4510bfa019b1c35a] Linux 5.5-rc1
git bisect good e42617b825f8073569da76dc4510bfa019b1c35a
# bad: [3778790e1d1329223601c63602286ad1d73c480f] Merge branch 'asoc-5.6' into asoc-next
git bisect bad 3778790e1d1329223601c63602286ad1d73c480f
# bad: [3e62579436c6a7fc35de7318e6c5f495b8d0046c] ASoC: SOF: core: modify the signature for snd_sof_create_page_table
git bisect bad 3e62579436c6a7fc35de7318e6c5f495b8d0046c
# good: [62d5ae4cafb7ffeeec6ba2dd1814cafeeea7dd8f] ASoC: max98090: save and restore SHDN when changing sensitive registers
git bisect good 62d5ae4cafb7ffeeec6ba2dd1814cafeeea7dd8f
# bad: [bc9a665581b3c6c82c9220a47f6573b49ce2df0b] ASoC: fix soc-core.c kernel-doc warning
git bisect bad bc9a665581b3c6c82c9220a47f6573b49ce2df0b
# bad: [abe3b6727b653307c27870a2d4ecbf9de4e914a5] ASoC: cs42l51: add dac mux widget in codec routes
git bisect bad abe3b6727b653307c27870a2d4ecbf9de4e914a5
# good: [49df1e3925824cf44e590daac635974270185841] ASoC: rsnd: Calculate DALIGN inversion at run-time
git bisect good 49df1e3925824cf44e590daac635974270185841
# first bad commit: [abe3b6727b653307c27870a2d4ecbf9de4e914a5] ASoC: cs42l51: add dac mux widget in codec routes
-------------------------------------------------------------------------------

Comments

Mark Brown Dec. 10, 2019, 1:08 p.m. UTC | #1
On Tue, Dec 10, 2019 at 04:51:51AM -0800, kernelci.org bot wrote:
>     ASoC: cs42l51: add dac mux widget in codec routes
>     
>     Add "DAC mux" DAPM widget in CS42l51 audio codec routes,
>     to support DAC mux control and to remove error trace
>     "DAC Mux has no paths" at widget creation.
>     Note: ADC path of DAC mux is not routed in this patch.

This doesn't seem right, as far as I can see this device is not present
on that board (it uses some Realtek and Maxim devices AFAICT).  Is it
some sort of timing thing?

Patch
diff mbox series

diff --git a/sound/soc/codecs/cs42l51.c b/sound/soc/codecs/cs42l51.c
index 55408c8fcb4e..e47758e4fb36 100644
--- a/sound/soc/codecs/cs42l51.c
+++ b/sound/soc/codecs/cs42l51.c
@@ -214,12 +214,10 @@  static const struct snd_soc_dapm_widget cs42l51_dapm_widgets[] = {
 	SND_SOC_DAPM_ADC_E("Right ADC", "Right HiFi Capture",
 		CS42L51_POWER_CTL1, 2, 1,
 		cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD),
-	SND_SOC_DAPM_DAC_E("Left DAC", "Left HiFi Playback",
-		CS42L51_POWER_CTL1, 5, 1,
-		cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD),
-	SND_SOC_DAPM_DAC_E("Right DAC", "Right HiFi Playback",
-		CS42L51_POWER_CTL1, 6, 1,
-		cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD),
+	SND_SOC_DAPM_DAC_E("Left DAC", NULL, CS42L51_POWER_CTL1, 5, 1,
+			   cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD),
+	SND_SOC_DAPM_DAC_E("Right DAC", NULL, CS42L51_POWER_CTL1, 6, 1,
+			   cs42l51_pdn_event, SND_SOC_DAPM_PRE_POST_PMD),
 
 	/* analog/mic */
 	SND_SOC_DAPM_INPUT("AIN1L"),
@@ -255,6 +253,12 @@  static const struct snd_soc_dapm_route cs42l51_routes[] = {
 	{"HPL", NULL, "Left DAC"},
 	{"HPR", NULL, "Right DAC"},
 
+	{"Right DAC", NULL, "DAC Mux"},
+	{"Left DAC", NULL, "DAC Mux"},
+
+	{"DAC Mux", "Direct PCM", "Playback"},
+	{"DAC Mux", "DSP PCM", "Playback"},
+
 	{"Left ADC", NULL, "Left PGA"},
 	{"Right ADC", NULL, "Right PGA"},
-------------------------------------------------------------------------------