From: Lukas Wunner <lukas@wunner.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: Jaroslav Kysela <perex@perex.cz>,
Alex Deucher <alexander.deucher@amd.com>,
Mika Westerberg <mika.westerberg@linux.intel.com>,
Bjorn Helgaas <helgaas@kernel.org>,
Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
linux-pci@vger.kernel.org
Subject: [PATCH] ALSA: hda/hdmi - Fix duplicate unref of pci_dev
Date: Tue, 10 Dec 2019 14:39:50 +0100 [thread overview]
Message-ID: <77aa6c01aefe1ebc4004e87b0bc714f2759f15c4.1575985006.git.lukas@wunner.de> (raw)
In-Reply-To: <PSXP216MB0438BFEAA0617283A834E11580580@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM>
Nicholas Johnson reports a null pointer deref as well as a refcount
underflow upon hot-removal of a Thunderbolt-attached AMD eGPU.
He's bisected the issue down to commit 586bc4aab878 ("ALSA: hda/hdmi -
fix vgaswitcheroo detection for AMD").
The commit iterates over PCI devices using pci_get_class() and
unreferences each device found, even though pci_get_class()
subsequently unreferences the device as well. Fix it.
Fixes: 586bc4aab878 ("ALSA: hda/hdmi - fix vgaswitcheroo detection for AMD")
Link: https://lore.kernel.org/r/PSXP216MB0438BFEAA0617283A834E11580580@PSXP216MB0438.KORP216.PROD.OUTLOOK.COM/
Reported-and-tested-by: Nicholas Johnson <nicholas.johnson-opensource@outlook.com.au>
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Cc: Alexander Deucher <alexander.deucher@amd.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>
---
sound/pci/hda/hda_intel.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/sound/pci/hda/hda_intel.c b/sound/pci/hda/hda_intel.c
index 35b4526f0d28..b856b89378ac 100644
--- a/sound/pci/hda/hda_intel.c
+++ b/sound/pci/hda/hda_intel.c
@@ -1419,7 +1419,6 @@ static bool atpx_present(void)
return true;
}
}
- pci_dev_put(pdev);
}
return false;
}
--
2.24.0
next prev parent reply other threads:[~2019-12-10 13:39 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-09 12:34 Linux v5.5 serious PCI bug Nicholas Johnson
2019-12-09 12:37 ` Pavel Machek
2019-12-09 13:07 ` Nicholas Johnson
2019-12-09 13:12 ` mika.westerberg
2019-12-09 13:29 ` Nicholas Johnson
2019-12-09 13:33 ` Nicholas Johnson
2019-12-10 7:28 ` mika.westerberg
2019-12-10 12:00 ` Nicholas Johnson
2019-12-10 12:29 ` Lukas Wunner
2019-12-10 12:46 ` Takashi Iwai
2019-12-11 7:33 ` Jiasen Lin
2019-12-10 12:52 ` Nicholas Johnson
2019-12-10 12:34 ` mika.westerberg
2019-12-10 13:39 ` Lukas Wunner [this message]
2019-12-10 13:41 ` [PATCH] ALSA: hda/hdmi - Fix duplicate unref of pci_dev Takashi Iwai
2019-12-10 13:47 ` Nicholas Johnson
2019-12-10 13:50 ` Takashi Iwai
2019-12-10 15:34 ` Deucher, Alexander
2019-12-10 15:46 ` Lukas Wunner
2019-12-10 15:53 ` Deucher, Alexander
2019-12-10 16:10 ` Takashi Iwai
2019-12-10 16:51 ` Deucher, Alexander
2019-12-10 16:13 ` Lukas Wunner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=77aa6c01aefe1ebc4004e87b0bc714f2759f15c4.1575985006.git.lukas@wunner.de \
--to=lukas@wunner.de \
--cc=alexander.deucher@amd.com \
--cc=alsa-devel@alsa-project.org \
--cc=helgaas@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mika.westerberg@linux.intel.com \
--cc=nicholas.johnson-opensource@outlook.com.au \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).