From: Brendan Higgins <brendanhiggins@google.com>
To: jdike@addtoit.com, richard@nod.at,
anton.ivanov@cambridgegreys.com,
Herbert Xu <herbert@gondor.apana.org.au>,
"David S. Miller" <davem@davemloft.net>,
Antoine Tenart <antoine.tenart@bootlin.com>
Cc: linux-um@lists.infradead.org, linux-kernel@vger.kernel.org,
davidgow@google.com, Brendan Higgins <brendanhiggins@google.com>,
linux-crypto@vger.kernel.org
Subject: [PATCH v1 4/7] crypto: inside-secure: add unspecified HAS_IOMEM dependency
Date: Wed, 11 Dec 2019 11:27:39 -0800 [thread overview]
Message-ID: <20191211192742.95699-5-brendanhiggins@google.com> (raw)
In-Reply-To: <20191211192742.95699-1-brendanhiggins@google.com>
Currently CONFIG_CRYPTO_DEV_SAFEXCEL=y implicitly depends on
CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get
the following build error:
ld: drivers/crypto/inside-secure/safexcel.o: in function `safexcel_probe':
drivers/crypto/inside-secure/safexcel.c:1692: undefined reference to `devm_platform_ioremap_resource'
Fix the build error by adding the unspecified dependency.
Reported-by: Brendan Higgins <brendanhiggins@google.com>
Signed-off-by: Brendan Higgins <brendanhiggins@google.com>
---
drivers/crypto/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig
index 91eb768d4221a..0a73bebd04e5d 100644
--- a/drivers/crypto/Kconfig
+++ b/drivers/crypto/Kconfig
@@ -716,7 +716,7 @@ source "drivers/crypto/stm32/Kconfig"
config CRYPTO_DEV_SAFEXCEL
tristate "Inside Secure's SafeXcel cryptographic engine driver"
- depends on OF || PCI || COMPILE_TEST
+ depends on (OF || PCI || COMPILE_TEST) && HAS_IOMEM
select CRYPTO_LIB_AES
select CRYPTO_AUTHENC
select CRYPTO_SKCIPHER
--
2.24.0.525.g8f36a354ae-goog
next prev parent reply other threads:[~2019-12-11 19:28 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 19:27 [PATCH v1 0/7] uml: add unspecified HAS_IOMEM dependencies Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 1/7] pinctrl: equilibrium: add unspecified HAS_IOMEM dependency Brendan Higgins
2019-12-16 8:42 ` Linus Walleij
2019-12-16 9:31 ` Arnd Bergmann
2019-12-16 10:39 ` Linus Walleij
2020-01-23 22:15 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 2/7] mtd: rawnand: " Brendan Higgins
2020-01-09 15:23 ` Miquel Raynal
2020-01-25 2:12 ` Brendan Higgins
2020-01-25 15:28 ` Miquel Raynal
2020-01-27 19:00 ` Brendan Higgins
2020-01-30 19:50 ` Miquel Raynal
2020-01-30 19:55 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 3/7] net: axienet: " Brendan Higgins
2019-12-12 5:45 ` Radhey Shyam Pandey
2019-12-11 19:27 ` Brendan Higgins [this message]
2019-12-20 7:07 ` [PATCH v1 4/7] crypto: inside-secure: " Herbert Xu
2019-12-11 19:27 ` [PATCH v1 5/7] crypto: amlogic: " Brendan Higgins
2019-12-12 19:36 ` LABBE Corentin
2019-12-20 7:07 ` Herbert Xu
2019-12-11 19:27 ` [PATCH v1 6/7] staging: axis-fifo: " Brendan Higgins
2019-12-14 11:28 ` Greg Kroah-Hartman
2020-01-23 22:16 ` Brendan Higgins
2019-12-11 19:27 ` [PATCH v1 7/7] fsi: aspeed: " Brendan Higgins
2019-12-12 0:12 ` Joel Stanley
2019-12-12 0:30 ` Brendan Higgins
2019-12-16 6:01 ` Joel Stanley
2020-01-27 9:46 ` Brendan Higgins
2020-01-31 3:43 ` Joel Stanley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211192742.95699-5-brendanhiggins@google.com \
--to=brendanhiggins@google.com \
--cc=antoine.tenart@bootlin.com \
--cc=anton.ivanov@cambridgegreys.com \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=jdike@addtoit.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-um@lists.infradead.org \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).