From: Soeren Moch <smoch@web.de>
To: Kalle Valo <kvalo@codeaurora.org>, Heiko Stuebner <heiko@sntech.de>
Cc: Soeren Moch <smoch@web.de>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Franky Lin <franky.lin@broadcom.com>,
Hante Meuleman <hante.meuleman@broadcom.com>,
Chi-Hsien Lin <chi-hsien.lin@cypress.com>,
Wright Feng <wright.feng@cypress.com>,
linux-wireless@vger.kernel.org,
brcm80211-dev-list.pdl@broadcom.com,
brcm80211-dev-list@cypress.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH v2 4/9] brcmfmac: make errors when setting roaming parameters non-fatal
Date: Thu, 12 Dec 2019 00:52:48 +0100 [thread overview]
Message-ID: <20191211235253.2539-5-smoch@web.de> (raw)
In-Reply-To: <20191211235253.2539-1-smoch@web.de>
4359 dongles do not support setting roaming parameters (error -52).
Do not fail the 80211 configuration in this case.
Signed-off-by: Soeren Moch <smoch@web.de>
Acked-by: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
---
changes in v2:
- add ack tag received for v1
Cc: Kalle Valo <kvalo@codeaurora.org>
Cc: Heiko Stuebner <heiko@sntech.de>
Cc: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: Franky Lin <franky.lin@broadcom.com>
Cc: Hante Meuleman <hante.meuleman@broadcom.com>
Cc: Chi-Hsien Lin <chi-hsien.lin@cypress.com>
Cc: Wright Feng <wright.feng@cypress.com>
Cc: linux-wireless@vger.kernel.org
Cc: brcm80211-dev-list.pdl@broadcom.com
Cc: brcm80211-dev-list@cypress.com
Cc: netdev@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-rockchip@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
---
.../wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
index 5598bbd09b62..0cf13cea1dbe 100644
--- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
+++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c
@@ -6012,19 +6012,17 @@ static s32 brcmf_dongle_roam(struct brcmf_if *ifp)
roamtrigger[1] = cpu_to_le32(BRCM_BAND_ALL);
err = brcmf_fil_cmd_data_set(ifp, BRCMF_C_SET_ROAM_TRIGGER,
(void *)roamtrigger, sizeof(roamtrigger));
- if (err) {
+ if (err)
bphy_err(drvr, "WLC_SET_ROAM_TRIGGER error (%d)\n", err);
- goto roam_setup_done;
- }
roam_delta[0] = cpu_to_le32(WL_ROAM_DELTA);
roam_delta[1] = cpu_to_le32(BRCM_BAND_ALL);
err = brcmf_fil_cmd_data_set(ifp, BRCMF_C_SET_ROAM_DELTA,
(void *)roam_delta, sizeof(roam_delta));
- if (err) {
+ if (err)
bphy_err(drvr, "WLC_SET_ROAM_DELTA error (%d)\n", err);
- goto roam_setup_done;
- }
+
+ return 0;
roam_setup_done:
return err;
--
2.17.1
next prev parent reply other threads:[~2019-12-11 23:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-11 23:52 [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset Soeren Moch
2019-12-11 23:52 ` [PATCH v2 1/9] brcmfmac: reset two D11 cores if chip has two D11 cores Soeren Moch
2019-12-18 19:08 ` Kalle Valo
2019-12-11 23:52 ` [PATCH v2 2/9] brcmfmac: set F2 blocksize and watermark for 4359 Soeren Moch
2019-12-11 23:52 ` [PATCH v2 3/9] brcmfmac: fix rambase for 4359/9 Soeren Moch
2019-12-12 2:07 ` Chi-Hsien Lin
2019-12-11 23:52 ` Soeren Moch [this message]
2019-12-11 23:52 ` [PATCH v2 5/9] brcmfmac: add support for BCM4359 SDIO chipset Soeren Moch
2019-12-12 1:02 ` Soeren Moch
2019-12-12 2:09 ` Chi-Hsien Lin
2019-12-12 8:33 ` Ulf Hansson
2019-12-11 23:52 ` [PATCH v2 6/9] brcmfmac: add RSDB condition when setting interface combinations Soeren Moch
2019-12-11 23:52 ` [PATCH v2 7/9] brcmfmac: not set mbss in vif if firmware does not support MBSS Soeren Moch
2019-12-11 23:52 ` [PATCH v2 8/9] arm64: dts: rockchip: RockPro64: enable wifi module at sdio0 Soeren Moch
2019-12-11 23:52 ` [PATCH v2 9/9] arm64: dts: rockchip: RockPro64: hook up bluetooth at uart0 Soeren Moch
2019-12-12 10:22 ` Robin Murphy
2019-12-12 10:47 ` Soeren Moch
2019-12-12 9:42 ` [PATCH v2 0/9] brcmfmac: add support for BCM4359 SDIO chipset Kalle Valo
[not found] ` <0101016ef97cf6b5-2552a5e4-12de-4616-94d6-b63d9c795ed6-000000@us-west-2.amazonses.com>
2019-12-12 10:59 ` Soeren Moch
2019-12-15 21:24 ` Soeren Moch
2019-12-15 23:43 ` Heiko Stübner
2020-03-13 11:03 ` Chi-Hsien Lin
2020-03-13 13:17 ` Soeren Moch
2020-03-15 7:01 ` Chi-Hsien Lin
2019-12-18 11:55 ` Christian Hewitt
2019-12-18 23:04 ` Soeren Moch
2019-12-22 4:35 ` Christian Hewitt
2019-12-24 9:01 ` Arend Van Spriel
2019-12-24 9:44 ` Christian Hewitt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211235253.2539-5-smoch@web.de \
--to=smoch@web.de \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211-dev-list.pdl@broadcom.com \
--cc=brcm80211-dev-list@cypress.com \
--cc=chi-hsien.lin@cypress.com \
--cc=franky.lin@broadcom.com \
--cc=hante.meuleman@broadcom.com \
--cc=heiko@sntech.de \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=wright.feng@cypress.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).