From: SeongJae Park <sj38.park@gmail.com>
To: brendanhiggins@google.com, shuah@kernel.org
Cc: sjpark@amazon.com, corbet@lwn.net, kunit-dev@googlegroups.com,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-kselftest@vger.kernel.org, sj38.park@gmail.com,
sjpark@amazon.de
Subject: [PATCH v6 6/6] kunit/kunit_tool_test: Test '--build_dir' option run
Date: Thu, 12 Dec 2019 02:27:11 +0000 [thread overview]
Message-ID: <20191212022711.10062-7-sjpark@amazon.de> (raw)
In-Reply-To: <20191212022711.10062-1-sjpark@amazon.de>
This commit adds kunit tool test for the '--build_dir' option.
Signed-off-by: SeongJae Park <sjpark@amazon.de>
Reviewed-by: Brendan Higgins <brendanhiggins@google.com>
Tested-by: Brendan Higgins <brendanhiggins@google.com>
---
tools/testing/kunit/kunit_tool_test.py | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/tools/testing/kunit/kunit_tool_test.py b/tools/testing/kunit/kunit_tool_test.py
index 22f16e66b3c1..cba97756ac4a 100755
--- a/tools/testing/kunit/kunit_tool_test.py
+++ b/tools/testing/kunit/kunit_tool_test.py
@@ -174,6 +174,7 @@ class KUnitMainTest(unittest.TestCase):
kunit.main(['run'], self.linux_source_mock)
assert self.linux_source_mock.build_reconfig.call_count == 1
assert self.linux_source_mock.run_kernel.call_count == 1
+ self.linux_source_mock.run_kernel.assert_called_once_with(build_dir='', timeout=300)
self.print_mock.assert_any_call(StrContains('Testing complete.'))
def test_run_passes_args_fail(self):
@@ -202,5 +203,12 @@ class KUnitMainTest(unittest.TestCase):
self.linux_source_mock.run_kernel.assert_called_once_with(build_dir='', timeout=timeout)
self.print_mock.assert_any_call(StrContains('Testing complete.'))
+ def test_run_builddir(self):
+ build_dir = '.kunit'
+ kunit.main(['run', '--build_dir', build_dir], self.linux_source_mock)
+ assert self.linux_source_mock.build_reconfig.call_count == 1
+ self.linux_source_mock.run_kernel.assert_called_once_with(build_dir=build_dir, timeout=300)
+ self.print_mock.assert_any_call(StrContains('Testing complete.'))
+
if __name__ == '__main__':
unittest.main()
--
2.17.1
next prev parent reply other threads:[~2019-12-12 2:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-12 2:27 [PATCH v6 0/6] Fix nits in the kunit SeongJae Park
2019-12-12 2:27 ` [PATCH v6 1/6] docs/kunit/start: Use in-tree 'kunit_defconfig' SeongJae Park
2019-12-12 2:27 ` [PATCH v6 2/6] kunit: Remove duplicated defconfig creation SeongJae Park
2019-12-12 2:27 ` [PATCH v6 3/6] kunit: Create default config in '--build_dir' SeongJae Park
2019-12-12 2:27 ` [PATCH v6 4/6] kunit: Place 'test.log' under the 'build_dir' SeongJae Park
2019-12-12 2:27 ` [PATCH v6 5/6] kunit: Rename 'kunitconfig' to '.kunitconfig' SeongJae Park
2019-12-12 2:27 ` SeongJae Park [this message]
2019-12-12 21:31 ` [PATCH v6 0/6] Fix nits in the kunit Brendan Higgins
2019-12-12 21:44 ` shuah
2019-12-19 23:37 ` shuah
2019-12-20 5:01 ` SeongJae Park
2019-12-20 5:18 ` SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212022711.10062-7-sjpark@amazon.de \
--to=sj38.park@gmail.com \
--cc=brendanhiggins@google.com \
--cc=corbet@lwn.net \
--cc=kunit-dev@googlegroups.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=sjpark@amazon.com \
--cc=sjpark@amazon.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).