From: zhenwei pi <pizhenwei@bytedance.com>
To: arnd@arndb.de, gregkh@linuxfoundation.org, peng.hao2@zte.com.cn
Cc: hutao@cn.fujitsu.com, linux-kernel@vger.kernel.org,
pizhenwei@bytedance.com
Subject: [PATCH v2 2/2] misc: pvpanic: add crash loaded event
Date: Sun, 15 Dec 2019 11:48:40 +0800 [thread overview]
Message-ID: <20191215034840.2273096-3-pizhenwei@bytedance.com> (raw)
In-Reply-To: <20191215034840.2273096-1-pizhenwei@bytedance.com>
Some users prefer kdump tools to generate guest kernel dumpfile,
at the same time, need a out-of-band kernel panic event.
Currently if booting guest kernel with 'crash_kexec_post_notifiers',
QEMU will receive PVPANIC_PANICKED event and stop VM. If booting
guest kernel without 'crash_kexec_post_notifiers', guest will not
call notifier chain.
Add PVPANIC_CRASH_LOADED bit for pvpanic event, it means that guest
kernel actually hit a kernel panic, but the guest kernel wants to
handle by itself.
Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>
---
drivers/misc/pvpanic.c | 9 ++++++++-
include/uapi/misc/pvpanic.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/misc/pvpanic.c b/drivers/misc/pvpanic.c
index 3f0de3be0a19..a6e1a8983e1f 100644
--- a/drivers/misc/pvpanic.c
+++ b/drivers/misc/pvpanic.c
@@ -10,6 +10,7 @@
#include <linux/acpi.h>
#include <linux/kernel.h>
+#include <linux/kexec.h>
#include <linux/module.h>
#include <linux/of.h>
#include <linux/of_address.h>
@@ -33,7 +34,13 @@ static int
pvpanic_panic_notify(struct notifier_block *nb, unsigned long code,
void *unused)
{
- pvpanic_send_event(PVPANIC_PANICKED);
+ unsigned int event = PVPANIC_PANICKED;
+
+ if (kexec_crash_loaded())
+ event = PVPANIC_CRASH_LOADED;
+
+ pvpanic_send_event(event);
+
return NOTIFY_DONE;
}
diff --git a/include/uapi/misc/pvpanic.h b/include/uapi/misc/pvpanic.h
index cae69a822b25..54b7485390d3 100644
--- a/include/uapi/misc/pvpanic.h
+++ b/include/uapi/misc/pvpanic.h
@@ -4,5 +4,6 @@
#define __PVPANIC_H__
#define PVPANIC_PANICKED (1 << 0)
+#define PVPANIC_CRASH_LOADED (1 << 1)
#endif /* __PVPANIC_H__ */
--
2.11.0
next prev parent reply other threads:[~2019-12-15 3:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-15 3:48 [PATCH v2 0/2] misc: pvpanic: add crash loaded event zhenwei pi
2019-12-15 3:48 ` [PATCH v2 1/2] misc: pvpanic: move bit definition to uapi header file zhenwei pi
2019-12-15 3:48 ` zhenwei pi [this message]
2020-01-18 20:56 ` [PATCH v2 0/2] misc: pvpanic: add crash loaded event Paolo Bonzini
2019-12-25 6:26 zhenwei pi
2019-12-25 6:26 ` [PATCH v2 2/2] " zhenwei pi
2020-01-02 2:35 [PATCH v2 0/2] " zhenwei pi
2020-01-02 2:35 ` [PATCH v2 2/2] " zhenwei pi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191215034840.2273096-3-pizhenwei@bytedance.com \
--to=pizhenwei@bytedance.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=hutao@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peng.hao2@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).