From: "Guido Günther" <agx@sigxcpu.org>
To: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>, Dan Murphy <dmurphy@ti.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] leds: lm3692x: Allow to set ovp and brigthness mode
Date: Mon, 16 Dec 2019 13:28:06 +0100 [thread overview]
Message-ID: <9c87a17aefbf758d58f199f7046114ee7505a1fa.1576499103.git.agx@sigxcpu.org> (raw)
In-Reply-To: <cover.1576499103.git.agx@sigxcpu.org>
Overvoltage protection and brightness mode are currently hardcoded
as disabled in the driver. Make these configurable via DT.
Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
drivers/leds/leds-lm3692x.c | 43 +++++++++++++++++++++++++++++++------
1 file changed, 37 insertions(+), 6 deletions(-)
diff --git a/drivers/leds/leds-lm3692x.c b/drivers/leds/leds-lm3692x.c
index 8b408102e138..2c084b333628 100644
--- a/drivers/leds/leds-lm3692x.c
+++ b/drivers/leds/leds-lm3692x.c
@@ -114,6 +114,7 @@ struct lm3692x_led {
struct regulator *regulator;
int led_enable;
int model_id;
+ u8 boost_ctrl, brightness_ctrl;
};
static const struct reg_default lm3692x_reg_defs[] = {
@@ -249,10 +250,7 @@ static int lm3692x_init(struct lm3692x_led *led)
if (ret)
goto out;
- ret = regmap_write(led->regmap, LM3692X_BOOST_CTRL,
- LM3692X_BOOST_SW_1MHZ |
- LM3692X_BOOST_SW_NO_SHIFT |
- LM3692X_OCP_PROT_1_5A);
+ ret = regmap_write(led->regmap, LM3692X_BOOST_CTRL, led->boost_ctrl);
if (ret)
goto out;
@@ -268,8 +266,7 @@ static int lm3692x_init(struct lm3692x_led *led)
if (ret)
goto out;
- ret = regmap_write(led->regmap, LM3692X_BRT_CTRL,
- LM3692X_BL_ADJ_POL | LM3692X_RAMP_EN);
+ ret = regmap_write(led->regmap, LM3692X_BRT_CTRL, led->brightness_ctrl);
if (ret)
goto out;
@@ -326,6 +323,8 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
{
struct fwnode_handle *child = NULL;
struct led_init_data init_data = {};
+ u32 ovp = 0;
+ bool exp_mode;
int ret;
led->enable_gpio = devm_gpiod_get_optional(&led->client->dev,
@@ -350,6 +349,38 @@ static int lm3692x_probe_dt(struct lm3692x_led *led)
led->regulator = NULL;
}
+ led->boost_ctrl = LM3692X_BOOST_SW_1MHZ |
+ LM3692X_BOOST_SW_NO_SHIFT |
+ LM3692X_OCP_PROT_1_5A;
+ ret = device_property_read_u32(&led->client->dev,
+ "ti,overvoltage-volts", &ovp);
+ if (!ret) {
+ switch (ovp) {
+ case 0:
+ break;
+ case 22:
+ led->boost_ctrl |= LM3692X_OVP_21V;
+ break;
+ case 25:
+ led->boost_ctrl |= LM3692X_OVP_25V;
+ break;
+ case 29:
+ led->boost_ctrl |= LM3692X_OVP_29V;
+ break;
+ default:
+ dev_err(&led->client->dev, "Invalid OVP %d\n", ovp);
+ return -EINVAL;
+ }
+ }
+ dev_dbg(&led->client->dev, "OVP: %dV", ovp);
+
+ led->brightness_ctrl = LM3692X_BL_ADJ_POL | LM3692X_RAMP_EN;
+ exp_mode = device_property_read_bool(&led->client->dev,
+ "ti,brightness-mapping-exponential");
+ dev_dbg(&led->client->dev, "Exponential brightness: %d", exp_mode);
+ if (exp_mode)
+ led->brightness_ctrl |= LM3692X_MAP_MODE_EXP;
+
child = device_get_next_child_node(&led->client->dev, child);
if (!child) {
dev_err(&led->client->dev, "No LED Child node\n");
--
2.23.0
next prev parent reply other threads:[~2019-12-16 12:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 12:28 [PATCH 0/2] leds: lm3692x: Allow to set ovp and brigthness mode Guido Günther
2019-12-16 12:28 ` [PATCH 1/2] dt: bindings: lm3692x: Document new properties Guido Günther
2019-12-17 12:41 ` Dan Murphy
2019-12-21 19:15 ` Pavel Machek
2019-12-24 11:45 ` Guido Günther
2019-12-26 19:19 ` Rob Herring
2019-12-27 10:16 ` Guido Günther
2019-12-16 12:28 ` Guido Günther [this message]
2019-12-17 12:53 ` [PATCH 2/2] leds: lm3692x: Allow to set ovp and brigthness mode Dan Murphy
2019-12-17 15:40 ` Guido Günther
2019-12-17 17:01 ` Dan Murphy
2019-12-21 19:17 ` Pavel Machek
2019-12-24 11:30 ` Guido Günther
2019-12-21 19:18 ` Pavel Machek
2019-12-24 11:26 ` Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c87a17aefbf758d58f199f7046114ee7505a1fa.1576499103.git.agx@sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).