From: SeongJae Park <sjpark@amazon.com>
To: <jgross@suse.com>, <axboe@kernel.dk>, <konrad.wilk@oracle.com>,
<roger.pau@citrix.com>
Cc: SeongJae Park <sjpark@amazon.de>, <pdurrant@amazon.com>,
<sjpark@amazon.com>, <sj38.park@gmail.com>,
<xen-devel@lists.xenproject.org>, <linux-block@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH v10 4/4] xen/blkback: Consistently insert one empty line between functions
Date: Mon, 16 Dec 2019 13:45:27 +0100 [thread overview]
Message-ID: <20191216124527.30306-5-sjpark@amazon.com> (raw)
In-Reply-To: <20191216124527.30306-1-sjpark@amazon.com>
From: SeongJae Park <sjpark@amazon.de>
The number of empty lines between functions in the xenbus.c is
inconsistent. This trivial style cleanup commit fixes the file to
consistently place only one empty line.
Acked-by: Roger Pau Monné <roger.pau@citrix.com>
Signed-off-by: SeongJae Park <sjpark@amazon.de>
---
drivers/block/xen-blkback/xenbus.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/block/xen-blkback/xenbus.c b/drivers/block/xen-blkback/xenbus.c
index 4f6ea4feca79..dc0ea123c74c 100644
--- a/drivers/block/xen-blkback/xenbus.c
+++ b/drivers/block/xen-blkback/xenbus.c
@@ -432,7 +432,6 @@ static void xenvbd_sysfs_delif(struct xenbus_device *dev)
device_remove_file(&dev->dev, &dev_attr_physical_device);
}
-
static void xen_vbd_free(struct xen_vbd *vbd)
{
if (vbd->bdev)
@@ -489,6 +488,7 @@ static int xen_vbd_create(struct xen_blkif *blkif, blkif_vdev_t handle,
handle, blkif->domid);
return 0;
}
+
static int xen_blkbk_remove(struct xenbus_device *dev)
{
struct backend_info *be = dev_get_drvdata(&dev->dev);
@@ -572,6 +572,7 @@ static void xen_blkbk_discard(struct xenbus_transaction xbt, struct backend_info
if (err)
dev_warn(&dev->dev, "writing feature-discard (%d)", err);
}
+
int xen_blkbk_barrier(struct xenbus_transaction xbt,
struct backend_info *be, int state)
{
@@ -656,7 +657,6 @@ static int xen_blkbk_probe(struct xenbus_device *dev,
return err;
}
-
/*
* Callback received when the hotplug scripts have placed the physical-device
* node. Read it and the mode node, and create a vbd. If the frontend is
@@ -748,7 +748,6 @@ static void backend_changed(struct xenbus_watch *watch,
}
}
-
/*
* Callback received when the frontend's state changes.
*/
@@ -823,7 +822,6 @@ static void frontend_changed(struct xenbus_device *dev,
}
}
-
/* Once a memory pressure is detected, squeeze free page pools for a while. */
static unsigned int buffer_squeeze_duration_ms = 10;
module_param_named(buffer_squeeze_duration_ms,
@@ -844,7 +842,6 @@ static void reclaim_memory(struct xenbus_device *dev)
/* ** Connection ** */
-
/*
* Write the physical details regarding the block device to the store, and
* switch to Connected state.
--
2.17.1
prev parent reply other threads:[~2019-12-16 12:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-16 12:45 [PATCH v10 0/4] xenbus/backend: Add a memory pressure handler callback SeongJae Park
2019-12-16 12:45 ` [PATCH v10 1/4] xenbus/backend: Add " SeongJae Park
2019-12-16 12:45 ` [PATCH v10 2/4] xen/blkback: Squeeze page pools if a memory pressure is detected SeongJae Park
2019-12-16 14:37 ` [Xen-devel] " SeongJae Park
2019-12-16 16:15 ` SeongJae Park
2019-12-16 16:23 ` Jürgen Groß
2019-12-16 19:48 ` SeongJae Park
2019-12-17 6:23 ` Jürgen Groß
2019-12-17 7:59 ` SeongJae Park
2019-12-17 8:16 ` Jürgen Groß
2019-12-17 8:30 ` SeongJae Park
2019-12-17 16:17 ` SeongJae Park
2019-12-17 11:39 ` Roger Pau Monné
2019-12-17 13:15 ` SeongJae Park
2019-12-17 13:51 ` Jürgen Groß
2019-12-16 12:45 ` [PATCH v10 3/4] xen/blkback: Remove unnecessary static variable name prefixes SeongJae Park
2019-12-16 12:45 ` SeongJae Park [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191216124527.30306-5-sjpark@amazon.com \
--to=sjpark@amazon.com \
--cc=axboe@kernel.dk \
--cc=jgross@suse.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pdurrant@amazon.com \
--cc=roger.pau@citrix.com \
--cc=sj38.park@gmail.com \
--cc=sjpark@amazon.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).