From: Claudiu Beznea <claudiu.beznea@microchip.com>
To: <boris.brezillon@bootlin.com>, <airlied@linux.ie>,
<nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>,
<lee.jones@linaro.org>, <sam@ravnborg.org>
Cc: <peda@axentia.se>, <dri-devel@lists.freedesktop.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: [PATCH v3 1/6] drm: atmel-hlcdc: use double rate for pixel clock only if supported
Date: Wed, 18 Dec 2019 14:28:24 +0200 [thread overview]
Message-ID: <1576672109-22707-2-git-send-email-claudiu.beznea@microchip.com> (raw)
In-Reply-To: <1576672109-22707-1-git-send-email-claudiu.beznea@microchip.com>
Doubled system clock should be used as pixel cock source only if this
is supported. This is emphasized by the value of
atmel_hlcdc_crtc::dc::desc::fixed_clksrc.
Fixes: a6eca2abdd42 ("drm: atmel-hlcdc: add config option for clock selection")
Signed-off-by: Claudiu Beznea <claudiu.beznea@microchip.com>
---
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
index f2e73e6d46b8..5040ed8d0871 100644
--- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
+++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c
@@ -95,14 +95,14 @@ static void atmel_hlcdc_crtc_mode_set_nofb(struct drm_crtc *c)
(adj->crtc_hdisplay - 1) |
((adj->crtc_vdisplay - 1) << 16));
+ prate = clk_get_rate(crtc->dc->hlcdc->sys_clk);
+ mode_rate = adj->crtc_clock * 1000;
if (!crtc->dc->desc->fixed_clksrc) {
+ prate *= 2;
cfg |= ATMEL_HLCDC_CLKSEL;
mask |= ATMEL_HLCDC_CLKSEL;
}
- prate = 2 * clk_get_rate(crtc->dc->hlcdc->sys_clk);
- mode_rate = adj->crtc_clock * 1000;
-
div = DIV_ROUND_UP(prate, mode_rate);
if (div < 2) {
div = 2;
--
2.7.4
next prev parent reply other threads:[~2019-12-18 12:28 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-18 12:28 [PATCH v3 0/6] fixes for atmel-hlcdc Claudiu Beznea
2019-12-18 12:28 ` Claudiu Beznea [this message]
2019-12-18 12:28 ` [PATCH v3 2/6] drm: atmel-hlcdc: enable clock before configuring timing engine Claudiu Beznea
2019-12-18 12:28 ` [PATCH v3 3/6] mfd: atmel-hlcdc: add struct device member to struct atmel_hlcdc_regmap Claudiu Beznea
2019-12-18 12:28 ` [PATCH v3 4/6] mfd: atmel-hlcdc: return in case of error Claudiu Beznea
2020-01-07 10:18 ` Lee Jones
2019-12-18 12:28 ` [PATCH v3 5/6] drm: atmel-hlcdc: prefer a lower pixel-clock than requested Claudiu Beznea
2020-01-02 9:08 ` Sam Ravnborg
2020-01-04 17:12 ` Sam Ravnborg
2020-01-06 9:25 ` Claudiu.Beznea
2020-01-06 19:02 ` Sam Ravnborg
2020-01-06 9:24 ` Claudiu.Beznea
2020-01-07 9:19 ` Peter Rosin
2019-12-18 12:28 ` [PATCH v3 6/6] Revert "drm: atmel-hlcdc: enable sys_clk during initalization." Claudiu Beznea
2020-01-02 9:05 ` [PATCH v3 0/6] fixes for atmel-hlcdc Sam Ravnborg
2020-01-02 16:05 ` Lee Jones
2020-01-02 16:21 ` Sam Ravnborg
2020-01-06 19:37 ` Sam Ravnborg
2020-01-07 10:17 ` [GIT PULL] Immutable branch between MFD and DRM due for the v5.6 merge window Lee Jones
2020-01-07 18:21 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576672109-22707-2-git-send-email-claudiu.beznea@microchip.com \
--to=claudiu.beznea@microchip.com \
--cc=airlied@linux.ie \
--cc=alexandre.belloni@bootlin.com \
--cc=boris.brezillon@bootlin.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=peda@axentia.se \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).