From: AceLan Kao <acelan.kao@canonical.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Harry Pan <harry.pan@intel.com>,
David Heinzelmann <heinzelmann.david@gmail.com>,
Andrey Konovalov <andreyknvl@google.com>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Mathieu Malaterre <malat@debian.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: hub: move resume delay at the head of all USB access functions
Date: Fri, 20 Dec 2019 10:59:17 +0800 [thread overview]
Message-ID: <20191220025917.11886-1-acelan.kao@canonical.com> (raw)
usb_control_msg() function should be called after the resume delay, or
you'll encounter the below errors sometime.
After the issue happens, have to re-plug the USB cable to recover.
[ 837.483573] hub 2-3:1.0: hub_ext_port_status failed (err = -71)
[ 837.490889] hub 2-3:1.0: hub_ext_port_status failed (err = -71)
[ 837.506780] usb 2-3-port4: cannot disable (err = -71)
Signed-off-by: AceLan Kao <acelan.kao@canonical.com>
---
drivers/usb/core/hub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
index f229ad6952c0..2fb2816b0d38 100644
--- a/drivers/usb/core/hub.c
+++ b/drivers/usb/core/hub.c
@@ -3522,6 +3522,7 @@ int usb_port_resume(struct usb_device *udev, pm_message_t msg)
}
}
+ msleep(USB_RESUME_TIMEOUT);
usb_lock_port(port_dev);
/* Skip the initial Clear-Suspend step for a remote wakeup */
@@ -3544,7 +3545,6 @@ int usb_port_resume(struct usb_device *udev, pm_message_t msg)
/* drive resume for USB_RESUME_TIMEOUT msec */
dev_dbg(&udev->dev, "usb %sresume\n",
(PMSG_IS_AUTO(msg) ? "auto-" : ""));
- msleep(USB_RESUME_TIMEOUT);
/* Virtual root hubs can trigger on GET_PORT_STATUS to
* stop resume signaling. Then finish the resume
--
2.17.1
next reply other threads:[~2019-12-20 2:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 2:59 AceLan Kao [this message]
2019-12-20 15:48 ` [PATCH] usb: hub: move resume delay at the head of all USB access functions Alan Stern
2019-12-23 4:29 ` AceLan Kao
2019-12-24 15:23 ` Alan Stern
2019-12-25 3:15 ` AceLan Kao
2019-12-26 4:13 ` Pan, Harry
2019-12-26 9:07 ` AceLan Kao
2020-01-02 21:37 ` Alan Stern
2020-01-03 5:26 ` Kai-Heng Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191220025917.11886-1-acelan.kao@canonical.com \
--to=acelan.kao@canonical.com \
--cc=Thinh.Nguyen@synopsys.com \
--cc=andreyknvl@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=harry.pan@intel.com \
--cc=heinzelmann.david@gmail.com \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=malat@debian.org \
--cc=nsaenzjulienne@suse.de \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).