From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Kishon Vijay Abraham I <kishon@ti.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
Subject: [PATCH RESEND] PCI: endpoint: Fix clearing start entry in configfs
Date: Fri, 20 Dec 2019 21:24:37 +0900 [thread overview]
Message-ID: <1576844677-24933-1-git-send-email-hayashi.kunihiko@socionext.com> (raw)
The value of 'start' entry is no change whenever writing 0 to configfs.
So the endpoint that stopped once can't restart.
The following command lines are an example restarting endpoint and
reprogramming configurations after receiving bus-reset.
echo 0 > controllers/66000000.pcie-ep/start
rm controllers/66000000.pcie-ep/func1
ln -s functions/pci_epf_test/func1 controllers/66000000.pcie-ep/
echo 1 > controllers/66000000.pcie-ep/start
However, the first 'echo' can't set 0 to 'start', so the last 'echo' can't
restart endpoint.
Fixes: d74679911610 ("PCI: endpoint: Introduce configfs entry for configuring EP functions")
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
---
drivers/pci/endpoint/pci-ep-cfs.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/pci/endpoint/pci-ep-cfs.c b/drivers/pci/endpoint/pci-ep-cfs.c
index d1288a0..4fead88 100644
--- a/drivers/pci/endpoint/pci-ep-cfs.c
+++ b/drivers/pci/endpoint/pci-ep-cfs.c
@@ -58,6 +58,7 @@ static ssize_t pci_epc_start_store(struct config_item *item, const char *page,
if (!start) {
pci_epc_stop(epc);
+ epc_group->start = 0;
return len;
}
--
2.7.4
next reply other threads:[~2019-12-20 12:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-20 12:24 Kunihiko Hayashi [this message]
2020-02-21 14:15 ` [PATCH RESEND] PCI: endpoint: Fix clearing start entry in configfs Lorenzo Pieralisi
2020-02-25 10:05 ` Kunihiko Hayashi
2020-02-25 10:18 ` Lorenzo Pieralisi
2020-02-25 11:12 ` Kishon Vijay Abraham I
2020-02-26 1:20 ` Kunihiko Hayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1576844677-24933-1-git-send-email-hayashi.kunihiko@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).