From: qiwuchen55@gmail.com
To: rjw@rjwysocki.net, viresh.kumar@linaro.org
Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
chenqiwu <chenqiwu@xiaomi.com>
Subject: [PATCH] cpufreq: powernow-k8: avoid use after free issue in cpufreq_notify_transition()
Date: Sat, 28 Dec 2019 10:57:04 +0800 [thread overview]
Message-ID: <1577501824-12152-1-git-send-email-qiwuchen55@gmail.com> (raw)
From: chenqiwu <chenqiwu@xiaomi.com>
There is a potential UAF issue in cpufreq_notify_transition() that the
cpufreq of current cpu has been released before using it. So we should
make a judgement and avoid it.
Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
drivers/cpufreq/powernow-k8.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/cpufreq/powernow-k8.c b/drivers/cpufreq/powernow-k8.c
index 2db2f17..7391eb0 100644
--- a/drivers/cpufreq/powernow-k8.c
+++ b/drivers/cpufreq/powernow-k8.c
@@ -913,6 +913,11 @@ static int transition_frequency_fidvid(struct powernow_k8_data *data,
freqs.new = find_khz_freq_from_fid(fid);
policy = cpufreq_cpu_get(smp_processor_id());
+ if (!policy) {
+ pr_debug("cpu %d: CPUFreq policy not found\n",
+ smp_processor_id());
+ return 1;
+ }
cpufreq_cpu_put(policy);
cpufreq_freq_transition_begin(policy, &freqs);
--
1.9.1
next reply other threads:[~2019-12-28 2:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-28 2:57 qiwuchen55 [this message]
2020-01-06 5:44 ` [PATCH] cpufreq: powernow-k8: avoid use after free issue in cpufreq_notify_transition() Viresh Kumar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1577501824-12152-1-git-send-email-qiwuchen55@gmail.com \
--to=qiwuchen55@gmail.com \
--cc=chenqiwu@xiaomi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).